Skip to content

Commit 2c2e5e9

Browse files
committed
firmware: exynos-acpm: Correct kerneldoc and use typical np argument name
Correct kerneldoc warnings after commit a8dc26a ("firmware: exynos-acpm: introduce devm_acpm_get_by_node()") changed the function prototype: exynos-acpm.c:672: warning: Function parameter or struct member 'acpm_np' not described in 'acpm_get_by_node' exynos-acpm.c:672: warning: expecting prototype for acpm_get_by_phandle(). Prototype was for acpm_get_by_node() instead While touching the lines, change the name of device_node pointer to 'np' to match convention. Fixes: a8dc26a ("firmware: exynos-acpm: introduce devm_acpm_get_by_node()") Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Reviewed-by: Tudor Ambarus <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krzysztof Kozlowski <[email protected]>
1 parent a8dc26a commit 2c2e5e9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/firmware/samsung/exynos-acpm.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -661,20 +661,20 @@ static void devm_acpm_release(struct device *dev, void *res)
661661
}
662662

663663
/**
664-
* acpm_get_by_phandle() - get the ACPM handle using DT phandle.
665-
* @dev: device pointer requesting ACPM handle.
666-
* @property: property name containing phandle on ACPM node.
664+
* acpm_get_by_node() - get the ACPM handle using node pointer.
665+
* @dev: device pointer requesting ACPM handle.
666+
* @np: ACPM device tree node.
667667
*
668668
* Return: pointer to handle on success, ERR_PTR(-errno) otherwise.
669669
*/
670670
static const struct acpm_handle *acpm_get_by_node(struct device *dev,
671-
struct device_node *acpm_np)
671+
struct device_node *np)
672672
{
673673
struct platform_device *pdev;
674674
struct device_link *link;
675675
struct acpm_info *acpm;
676676

677-
pdev = of_find_device_by_node(acpm_np);
677+
pdev = of_find_device_by_node(np);
678678
if (!pdev)
679679
return ERR_PTR(-EPROBE_DEFER);
680680

0 commit comments

Comments
 (0)