Skip to content

Commit 2c34f6f

Browse files
truhuantorvalds
authored andcommitted
stacktrace: cleanup inconsistent variable type
Modify the variable type of 'skip' member of struct stack_trace. In theory, the 'skip' variable type should be unsigned int. There are two reasons: - The 'skip' only has two situation, 1)Positive value, 2)Zero - The 'skip' of struct stack_trace has inconsistent type with struct stack_trace_data, it makes a bit confusion in the relationship between struct stack_trace and stack_trace_data. Signed-off-by: Walter Wu <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Reviewed-by: Bart Van Assche <[email protected]> Cc: Matthias Brugger <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Josh Poimboeuf <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Linus Torvalds <[email protected]>
1 parent 6af132f commit 2c34f6f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/stacktrace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ void arch_stack_walk_user(stack_trace_consume_fn consume_entry, void *cookie,
6464
struct stack_trace {
6565
unsigned int nr_entries, max_entries;
6666
unsigned long *entries;
67-
int skip; /* input argument: How many entries to skip */
67+
unsigned int skip; /* input argument: How many entries to skip */
6868
};
6969

7070
extern void save_stack_trace(struct stack_trace *trace);

0 commit comments

Comments
 (0)