Skip to content

Commit 2c5947c

Browse files
chunkeeymiquelraynal
authored andcommitted
Revert "mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash"
This reverts commit 3380557. It turned out this "4-byte" ID might have been an honest mistake. Regrettably, the chip Andreas has might be a counterfeit or is damaged in some other way and shouldn't have ended up in a router. Andreas reported his chip is returning just four bytes: "98 f1 80 15 00 00 00 00". However, according to Kioxia/Toshiba's datasheet, there should have been at least another byte that would have contained the correct OOB size that Andreas needed. Miquel and Andreas are both favoring reverting the patch over further, possibly hacky modifications: "[Reverting] is the safest option here. Apart from this device, we do not know how many devices have these damaged/counterfeit chips. If it is just a couple and only on Fritzboxes, as suggested in the Github issue the patch could be carried through OpenWrt[...]" Thanks to several users on the openwrt forum and github issue, who stayed along for the ride: - Peter-vdL for reporting the issue and testing patches. - neg2led and Hannu Nyman who did all the datasheet digging and debugging. Cc: Andreas Boehler <[email protected]> Suggested-by: Andreas Boehler <[email protected]> Suggested-by: Miquel Raynal <[email protected]> Link: openwrt/openwrt#9962 Signed-off-by: Christian Lamparter <[email protected]> Signed-off-by: Miquel Raynal <[email protected]> Link: https://lore.kernel.org/linux-mtd/[email protected]
1 parent f2906aa commit 2c5947c

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/mtd/nand/raw/nand_ids.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ struct nand_flash_dev nand_flash_ids[] = {
2929
{"TC58NVG0S3E 1G 3.3V 8-bit",
3030
{ .id = {0x98, 0xd1, 0x90, 0x15, 0x76, 0x14, 0x01, 0x00} },
3131
SZ_2K, SZ_128, SZ_128K, 0, 8, 64, NAND_ECC_INFO(1, SZ_512), },
32-
{"TC58NVG0S3HTA00 1G 3.3V 8-bit",
33-
{ .id = {0x98, 0xf1, 0x80, 0x15} },
34-
SZ_2K, SZ_128, SZ_128K, 0, 4, 128, NAND_ECC_INFO(8, SZ_512), },
3532
{"TC58NVG2S0F 4G 3.3V 8-bit",
3633
{ .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08} },
3734
SZ_4K, SZ_512, SZ_256K, 0, 8, 224, NAND_ECC_INFO(4, SZ_512) },

0 commit comments

Comments
 (0)