Skip to content

Commit 2c5ac02

Browse files
andy-shevkuba-moo
authored andcommitted
net: phy: Introduce PHY_ID_SIZE — minimum size for PHY ID string
The PHY_ID_FMT defines the format specifier "%s:%02x" to form the PHY ID string, where the maximum of the first part is defined in MII_BUS_ID_SIZE, including NUL terminator, and the second part is implied to be 3 as the maximum address is limited to 32, meaning that 2 hex digits is more than enough, plus ':' (colon) delimiter. However, some drivers, which are using PHY_ID_FMT, customise buffer size and do that incorrectly. Introduce a new constant PHY_ID_SIZE that makes the minimum required size explicit, so drivers are encouraged to use it. Suggested-by: "Russell King (Oracle)" <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Russell King (Oracle) <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 4f74a45 commit 2c5ac02

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

include/linux/phy.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ static inline long rgmii_clock(int speed)
292292

293293
/* Used when trying to connect to a specific phy (mii bus id:phy device id) */
294294
#define PHY_ID_FMT "%s:%02x"
295+
#define PHY_ID_SIZE (MII_BUS_ID_SIZE + 3)
295296

296297
#define MII_BUS_ID_SIZE 61
297298

0 commit comments

Comments
 (0)