Skip to content

Commit 2ca376e

Browse files
committed
dt-bindings: HID: i2c-hid: Add "panel" property to i2c-hid backed touchscreens
As talked about in the patch ("drm/panel: Add a way for other devices to follow panel state"), touchscreens that are connected to panels are generally expected to be power sequenced together with the panel they're attached to. Today, nothing provides information allowing you to find out that a touchscreen is connected to a panel. Let's add a phandle for this. The proerty is added to the generic touchscreen bindings and then enabled in the bindings for the i2c-hid backed devices. This can and should be added for other touchscreens in the future, but for now let's start small. Reviewed-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Maxime Ripard <[email protected]> Reviewed-by: Benjamin Tissoires <[email protected]> Acked-by: Benjamin Tissoires <[email protected]> Signed-off-by: Douglas Anderson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/20230727101636.v4.1.Id68e30343bb1e11470582a9078b086176cfec46b@changeid
1 parent 8229399 commit 2ca376e

File tree

4 files changed

+19
-0
lines changed

4 files changed

+19
-0
lines changed

Documentation/devicetree/bindings/input/elan,ekth6915.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ description:
1313
Supports the Elan eKTH6915 touchscreen controller.
1414
This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
1515

16+
allOf:
17+
- $ref: /schemas/input/touchscreen/touchscreen.yaml#
18+
1619
properties:
1720
compatible:
1821
items:
@@ -24,6 +27,8 @@ properties:
2427
interrupts:
2528
maxItems: 1
2629

30+
panel: true
31+
2732
reset-gpios:
2833
description: Reset GPIO; not all touchscreens using eKTH6915 hook this up.
2934

Documentation/devicetree/bindings/input/goodix,gt7375p.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ description:
1414
This touchscreen uses the i2c-hid protocol but has some non-standard
1515
power sequencing required.
1616

17+
allOf:
18+
- $ref: /schemas/input/touchscreen/touchscreen.yaml#
19+
1720
properties:
1821
compatible:
1922
oneOf:
@@ -30,6 +33,8 @@ properties:
3033
interrupts:
3134
maxItems: 1
3235

36+
panel: true
37+
3338
reset-gpios:
3439
true
3540

Documentation/devicetree/bindings/input/hid-over-i2c.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ properties:
4444
description: HID descriptor address
4545
$ref: /schemas/types.yaml#/definitions/uint32
4646

47+
panel: true
48+
4749
post-power-on-delay-ms:
4850
description: Time required by the device after enabling its regulators
4951
or powering it on, before it is ready for communication.

Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@ maintainers:
1010
- Dmitry Torokhov <[email protected]>
1111

1212
properties:
13+
panel:
14+
description: If this touchscreen is integrally connected to a panel, this
15+
is a reference to that panel. The presence of this reference indicates
16+
that the touchscreen should be power sequenced together with the panel
17+
and that they may share power and/or reset signals.
18+
$ref: /schemas/types.yaml#/definitions/phandle
19+
1320
touchscreen-min-x:
1421
description: minimum x coordinate reported
1522
$ref: /schemas/types.yaml#/definitions/uint32

0 commit comments

Comments
 (0)