Skip to content

Commit 2ca9e47

Browse files
computersforpeacemmind
authored andcommitted
soc: rockchip: power-domain: Replace dsb() with smb()
It's unclear if these are really needed at all, but seemingly their purpose is only as a write barrier. Use the general macro instead of the ARM-specific one. This driver is partially marked for COMPILE_TEST'ing, but it doesn't build under non-ARM architectures. Fix this up before *really* enabling it for COMPILE_TEST. Signed-off-by: Brian Norris <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 9be1a99 commit 2ca9e47

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/soc/rockchip/pm_domains.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ static int rockchip_pmu_set_idle_request(struct rockchip_pm_domain *pd,
178178
regmap_update_bits(pmu->regmap, pmu->info->req_offset,
179179
pd_info->req_mask, idle ? -1U : 0);
180180

181-
dsb(sy);
181+
wmb();
182182

183183
/* Wait util idle_ack = 1 */
184184
target_ack = idle ? pd_info->ack_mask : 0;
@@ -285,7 +285,7 @@ static void rockchip_do_pmu_set_power_domain(struct rockchip_pm_domain *pd,
285285
regmap_update_bits(pmu->regmap, pmu->info->pwr_offset,
286286
pd->info->pwr_mask, on ? 0 : -1U);
287287

288-
dsb(sy);
288+
wmb();
289289

290290
if (readx_poll_timeout_atomic(rockchip_pmu_domain_is_on, pd, is_on,
291291
is_on == on, 0, 10000)) {

0 commit comments

Comments
 (0)