Skip to content

Commit 2cd0d1d

Browse files
LegoLivesMatterlag-linaro
authored andcommitted
leds: expresswire: Don't depend on NEW_LEDS
The ExpressWire library does not depend on NEW_LEDS and selecting it from a subsystem other than LEDs may cause Kconfig warnings: WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] Selected by [y]: - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] Move it out of the "if NEW_LEDS" block to allow selection from other subsystems (in particular backlight) without raising this warning. Reported-by: Arnd Bergmann <[email protected]> Closes: https://lore.kernel.org/[email protected] Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Suggested-by: Daniel Thompson <[email protected]> Fixes: 25ae5f5 ("leds: Introduce ExpressWire library") Reviewed-by: Daniel Thompson <[email protected]> Signed-off-by: Duje Mihanović <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
1 parent 041d2a0 commit 2cd0d1d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/leds/Kconfig

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ config LEDS_GPIO_REGISTER
66
As this function is used by arch code it must not be compiled as a
77
module.
88

9+
# This library does not depend on NEW_LEDS and must be independent so it can be
10+
# selected from other subsystems (specifically backlight).
11+
config LEDS_EXPRESSWIRE
12+
bool
13+
depends on GPIOLIB
14+
915
menuconfig NEW_LEDS
1016
bool "LED Support"
1117
help

0 commit comments

Comments
 (0)