Skip to content

Commit 2cebf68

Browse files
Mani-Sadhasivamkwilczynski
authored andcommitted
PCI: dwc: Rename 'dw_pcie::link_gen' to 'dw_pcie::max_link_speed'
The 'link_gen' field is now holding the maximum supported link speed set either by the controller driver or by DT through 'max-link-speed' property. However, the name 'link_gen' sounds like the negotiated link speed of the PCIe link. So rename it to 'max_link_speed' to make it clear that it holds the maximum supported link speed of the controller. Link: https://lore.kernel.org/linux-pci/[email protected] Tested-by: Johan Hovold <[email protected]> Signed-off-by: Manivannan Sadhasivam <[email protected]> [kwilczynski: commit log] Signed-off-by: Krzysztof Wilczyński <[email protected]> Reviewed-by: Frank Li <[email protected]> Reviewed-by: Johan Hovold <[email protected]>
1 parent d3745e3 commit 2cebf68

File tree

6 files changed

+17
-17
lines changed

6 files changed

+17
-17
lines changed

drivers/pci/controller/dwc/pci-imx6.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -847,12 +847,12 @@ static int imx6_pcie_start_link(struct dw_pcie *pci)
847847
if (ret)
848848
goto err_reset_phy;
849849

850-
if (pci->link_gen > 1) {
850+
if (pci->max_link_speed > 1) {
851851
/* Allow faster modes after the link is up */
852852
dw_pcie_dbi_ro_wr_en(pci);
853853
tmp = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCAP);
854854
tmp &= ~PCI_EXP_LNKCAP_SLS;
855-
tmp |= pci->link_gen;
855+
tmp |= pci->max_link_speed;
856856
dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, tmp);
857857

858858
/*
@@ -1386,8 +1386,8 @@ static int imx6_pcie_probe(struct platform_device *pdev)
13861386
imx6_pcie->tx_swing_low = 127;
13871387

13881388
/* Limit link speed */
1389-
pci->link_gen = 1;
1390-
of_property_read_u32(node, "fsl,max-link-speed", &pci->link_gen);
1389+
pci->max_link_speed = 1;
1390+
of_property_read_u32(node, "fsl,max-link-speed", &pci->max_link_speed);
13911391

13921392
imx6_pcie->vpcie = devm_regulator_get_optional(&pdev->dev, "vpcie");
13931393
if (IS_ERR(imx6_pcie->vpcie)) {

drivers/pci/controller/dwc/pcie-designware.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ int dw_pcie_get_resources(struct dw_pcie *pci)
168168
return ret;
169169
}
170170

171-
if (pci->link_gen < 1)
172-
pci->link_gen = of_pci_get_max_link_speed(np);
171+
if (pci->max_link_speed < 1)
172+
pci->max_link_speed = of_pci_get_max_link_speed(np);
173173

174174
of_property_read_u32(np, "num-lanes", &pci->num_lanes);
175175

@@ -689,7 +689,7 @@ void dw_pcie_upconfig_setup(struct dw_pcie *pci)
689689
}
690690
EXPORT_SYMBOL_GPL(dw_pcie_upconfig_setup);
691691

692-
static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen)
692+
static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 max_link_speed)
693693
{
694694
u32 cap, ctrl2, link_speed;
695695
u8 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
@@ -698,7 +698,7 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen)
698698
ctrl2 = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCTL2);
699699
ctrl2 &= ~PCI_EXP_LNKCTL2_TLS;
700700

701-
switch (pcie_link_speed[link_gen]) {
701+
switch (pcie_link_speed[max_link_speed]) {
702702
case PCIE_SPEED_2_5GT:
703703
link_speed = PCI_EXP_LNKCTL2_TLS_2_5GT;
704704
break;
@@ -1060,8 +1060,8 @@ void dw_pcie_setup(struct dw_pcie *pci)
10601060
{
10611061
u32 val;
10621062

1063-
if (pci->link_gen > 0)
1064-
dw_pcie_link_set_max_speed(pci, pci->link_gen);
1063+
if (pci->max_link_speed > 0)
1064+
dw_pcie_link_set_max_speed(pci, pci->max_link_speed);
10651065

10661066
/* Configure Gen1 N_FTS */
10671067
if (pci->n_fts[0]) {

drivers/pci/controller/dwc/pcie-designware.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ struct dw_pcie {
423423
u32 type;
424424
unsigned long caps;
425425
int num_lanes;
426-
int link_gen;
426+
int max_link_speed;
427427
u8 n_fts[2];
428428
struct dw_edma_chip edma;
429429
struct clk_bulk_data app_clks[DW_PCIE_NUM_APP_CLKS];

drivers/pci/controller/dwc/pcie-intel-gw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ static void intel_pcie_link_setup(struct intel_pcie *pcie)
132132

133133
static void intel_pcie_init_n_fts(struct dw_pcie *pci)
134134
{
135-
switch (pci->link_gen) {
135+
switch (pci->max_link_speed) {
136136
case 3:
137137
pci->n_fts[1] = PORT_AFR_N_FTS_GEN3;
138138
break;
@@ -252,7 +252,7 @@ static int intel_pcie_wait_l2(struct intel_pcie *pcie)
252252
int ret;
253253
struct dw_pcie *pci = &pcie->pci;
254254

255-
if (pci->link_gen < 3)
255+
if (pci->max_link_speed < 3)
256256
return 0;
257257

258258
/* Send PME_TURN_OFF message */

drivers/pci/controller/dwc/pcie-rcar-gen4.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,10 @@ static int rcar_gen4_pcie_start_link(struct dw_pcie *dw)
141141
}
142142

143143
/*
144-
* Require direct speed change with retrying here if the link_gen is
145-
* PCIe Gen2 or higher.
144+
* Require direct speed change with retrying here if the max_link_speed
145+
* is PCIe Gen2 or higher.
146146
*/
147-
changes = min_not_zero(dw->link_gen, RCAR_MAX_LINK_SPEED) - 1;
147+
changes = min_not_zero(dw->max_link_speed, RCAR_MAX_LINK_SPEED) - 1;
148148

149149
/*
150150
* Since dw_pcie_setup_rc() sets it once, PCIe Gen2 will be trained.

drivers/pci/controller/dwc/pcie-spear13xx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static int spear13xx_pcie_probe(struct platform_device *pdev)
233233
}
234234

235235
if (of_property_read_bool(np, "st,pcie-is-gen1"))
236-
pci->link_gen = 1;
236+
pci->max_link_speed = 1;
237237

238238
platform_set_drvdata(pdev, spear13xx_pcie);
239239

0 commit comments

Comments
 (0)