Skip to content

Commit 2cf1502

Browse files
paliLorenzo Pieralisi
authored andcommitted
PCI: mvebu: Do not modify PCI IO type bits in conf_write
PCI IO type bits are already initialized in mvebu_pci_bridge_emul_init() function and only when IO support is enabled. These type bits are read-only and pci-bridge-emul.c code already does not allow to modify them from upper layers. When IO support is disabled then all IO registers should be read-only and return zeros. Therefore do not modify PCI IO type bits in mvebu_pci_bridge_emul_base_conf_write() callback. Link: https://lore.kernel.org/r/[email protected] Fixes: 1f08673 ("PCI: mvebu: Convert to PCI emulated bridge config space") Signed-off-by: Pali Rohár <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]>
1 parent e42b855 commit 2cf1502

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/pci/controller/pci-mvebu.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -511,13 +511,6 @@ mvebu_pci_bridge_emul_base_conf_write(struct pci_bridge_emul *bridge,
511511
break;
512512

513513
case PCI_IO_BASE:
514-
/*
515-
* We keep bit 1 set, it is a read-only bit that
516-
* indicates we support 32 bits addressing for the
517-
* I/O
518-
*/
519-
conf->iobase |= PCI_IO_RANGE_TYPE_32;
520-
conf->iolimit |= PCI_IO_RANGE_TYPE_32;
521514
mvebu_pcie_handle_iobase_change(port);
522515
break;
523516

0 commit comments

Comments
 (0)