Skip to content

Commit 2d3c823

Browse files
Uwe Kleine-Königrafaeljw
authored andcommitted
thermal: lvts: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <[email protected]> Acked-by: Daniel Lezcano <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 3ebaf0f commit 2d3c823

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/thermal/mediatek/lvts_thermal.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,7 +1241,7 @@ static int lvts_probe(struct platform_device *pdev)
12411241
return 0;
12421242
}
12431243

1244-
static int lvts_remove(struct platform_device *pdev)
1244+
static void lvts_remove(struct platform_device *pdev)
12451245
{
12461246
struct lvts_domain *lvts_td;
12471247
int i;
@@ -1252,8 +1252,6 @@ static int lvts_remove(struct platform_device *pdev)
12521252
lvts_ctrl_set_enable(&lvts_td->lvts_ctrl[i], false);
12531253

12541254
lvts_debugfs_exit(lvts_td);
1255-
1256-
return 0;
12571255
}
12581256

12591257
static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = {
@@ -1354,7 +1352,7 @@ MODULE_DEVICE_TABLE(of, lvts_of_match);
13541352

13551353
static struct platform_driver lvts_driver = {
13561354
.probe = lvts_probe,
1357-
.remove = lvts_remove,
1355+
.remove_new = lvts_remove,
13581356
.driver = {
13591357
.name = "mtk-lvts-thermal",
13601358
.of_match_table = lvts_of_match,

0 commit comments

Comments
 (0)