Skip to content

Commit 2d5a333

Browse files
arndbkeithbusch
authored andcommitted
nvme-tcp: fix link failure for TCP auth
The nvme fabric driver calls the nvme_tls_key_lookup() function from nvmf_parse_key() when the keyring is enabled, but this is broken in a configuration with CONFIG_NVME_FABRICS=y and CONFIG_NVME_TCP=m because this leads to the function definition being in a loadable module: x86_64-linux-ld: vmlinux.o: in function `nvmf_parse_key': fabrics.c:(.text+0xb1bdec): undefined reference to `nvme_tls_key_lookup' Move the 'select' up to CONFIG_NVME_FABRICS itself to force this part to be built-in as well if needed. Fixes: 5bc46b4 ("nvme-tcp: check for invalidated or revoked key") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Sagi Grimberg <[email protected]> Signed-off-by: Keith Busch <[email protected]>
1 parent 389e72c commit 2d5a333

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/nvme/host/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ config NVME_HWMON
4141

4242
config NVME_FABRICS
4343
select NVME_CORE
44+
select NVME_KEYRING if NVME_TCP_TLS
4445
tristate
4546

4647
config NVME_RDMA
@@ -94,7 +95,6 @@ config NVME_TCP
9495
config NVME_TCP_TLS
9596
bool "NVMe over Fabrics TCP TLS encryption support"
9697
depends on NVME_TCP
97-
select NVME_KEYRING
9898
select NET_HANDSHAKE
9999
select KEYS
100100
help

0 commit comments

Comments
 (0)