Skip to content

Commit 2dbe5f1

Browse files
Doug Bergerdavem330
authored andcommitted
net: bcmgenet: synchronize use of bcmgenet_set_rx_mode()
The ndo_set_rx_mode function is synchronized with the netif_addr_lock spinlock and BHs disabled. Since this function is also invoked directly from the driver the same synchronization should be applied. Fixes: 72f9634 ("net: bcmgenet: set Rx mode before starting netif") Cc: [email protected] Signed-off-by: Doug Berger <[email protected]> Acked-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent d85cf67 commit 2dbe5f1

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/net/ethernet/broadcom/genet/bcmgenet.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/*
33
* Broadcom GENET (Gigabit Ethernet) controller driver
44
*
5-
* Copyright (c) 2014-2020 Broadcom
5+
* Copyright (c) 2014-2024 Broadcom
66
*/
77

88
#define pr_fmt(fmt) "bcmgenet: " fmt
@@ -3334,7 +3334,9 @@ static void bcmgenet_netif_start(struct net_device *dev)
33343334
struct bcmgenet_priv *priv = netdev_priv(dev);
33353335

33363336
/* Start the network engine */
3337+
netif_addr_lock_bh(dev);
33373338
bcmgenet_set_rx_mode(dev);
3339+
netif_addr_unlock_bh(dev);
33383340
bcmgenet_enable_rx_napi(priv);
33393341

33403342
umac_enable_set(priv, CMD_TX_EN | CMD_RX_EN, true);

0 commit comments

Comments
 (0)