gpio: uniphier: Fix void functions to remove return value

khayash1 · brgl · commit 2dd824cca340 · 2021-09-22T11:19:29.000+02:00
The return type of irq_chip.irq_mask() and irq_chip.irq_unmask() should be void. Fixes: dbe776c ("gpio: uniphier: add UniPhier GPIO controller driver") Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
@@ -184,7 +184,7 @@ static void uniphier_gpio_irq_mask(struct irq_data *data)
 
 	uniphier_gpio_reg_update(priv, UNIPHIER_GPIO_IRQ_EN, mask, 0);
 
-	return irq_chip_mask_parent(data);
+	irq_chip_mask_parent(data);
 }
 
 static void uniphier_gpio_irq_unmask(struct irq_data *data)
@@ -194,7 +194,7 @@ static void uniphier_gpio_irq_unmask(struct irq_data *data)
 
 	uniphier_gpio_reg_update(priv, UNIPHIER_GPIO_IRQ_EN, mask, mask);
 
-	return irq_chip_unmask_parent(data);
+	irq_chip_unmask_parent(data);
 }
 
 static int uniphier_gpio_irq_set_type(struct irq_data *data, unsigned int type)

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ static void uniphier_gpio_irq_mask(struct irq_data *data)`
`184`	`184`
`185`	`185`	`uniphier_gpio_reg_update(priv, UNIPHIER_GPIO_IRQ_EN, mask, 0);`
`186`	`186`
`187`		`- return irq_chip_mask_parent(data);`
	`187`	`+ irq_chip_mask_parent(data);`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`static void uniphier_gpio_irq_unmask(struct irq_data *data)`
`@@ -194,7 +194,7 @@ static void uniphier_gpio_irq_unmask(struct irq_data *data)`
`194`	`194`
`195`	`195`	`uniphier_gpio_reg_update(priv, UNIPHIER_GPIO_IRQ_EN, mask, mask);`
`196`	`196`
`197`		`- return irq_chip_unmask_parent(data);`
	`197`	`+ irq_chip_unmask_parent(data);`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`static int uniphier_gpio_irq_set_type(struct irq_data *data, unsigned int type)`