Skip to content

Commit 2e02da1

Browse files
gscuidlezcano
authored andcommitted
clocksource/drivers/cadence-ttc: Add missing clk_disable_unprepare in ttc_setup_clockevent
Add the missing clk_disable_unprepare() before return in ttc_setup_clockevent(). Signed-off-by: Gaosheng Cui <[email protected]> Reviewed-by: Michal Simek <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Daniel Lezcano <[email protected]>
1 parent 6cc11b6 commit 2e02da1

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/clocksource/timer-cadence-ttc.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ static int __init ttc_setup_clockevent(struct clk *clk,
435435
&ttcce->ttc.clk_rate_change_nb);
436436
if (err) {
437437
pr_warn("Unable to register clock notifier.\n");
438-
goto out_kfree;
438+
goto out_clk_unprepare;
439439
}
440440

441441
ttcce->ttc.freq = clk_get_rate(ttcce->ttc.clk);
@@ -465,13 +465,15 @@ static int __init ttc_setup_clockevent(struct clk *clk,
465465
err = request_irq(irq, ttc_clock_event_interrupt,
466466
IRQF_TIMER, ttcce->ce.name, ttcce);
467467
if (err)
468-
goto out_kfree;
468+
goto out_clk_unprepare;
469469

470470
clockevents_config_and_register(&ttcce->ce,
471471
ttcce->ttc.freq / PRESCALE, 1, 0xfffe);
472472

473473
return 0;
474474

475+
out_clk_unprepare:
476+
clk_disable_unprepare(ttcce->ttc.clk);
475477
out_kfree:
476478
kfree(ttcce);
477479
return err;

0 commit comments

Comments
 (0)