Skip to content

Commit 2e91bb9

Browse files
jtornosmkuba-moo
authored andcommitted
net: usb: ax88179_178a: avoid the interface always configured as random address
After the commit d2689b6 ("net: usb: ax88179_178a: avoid two consecutive device resets"), reset is not executed from bind operation and mac address is not read from the device registers or the devicetree at that moment. Since the check to configure if the assigned mac address is random or not for the interface, happens after the bind operation from usbnet_probe, the interface keeps configured as random address, although the address is correctly read and set during open operation (the only reset now). In order to keep only one reset for the device and to avoid the interface always configured as random address, after reset, configure correctly the suitable field from the driver, if the mac address is read successfully from the device registers or the devicetree. Take into account if a locally administered address (random) was previously stored. cc: [email protected] # 6.6+ Fixes: d2689b6 ("net: usb: ax88179_178a: avoid two consecutive device resets") Reported-by: Dave Stevenson <[email protected]> Signed-off-by: Jose Ignacio Tornos Martinez <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c120209 commit 2e91bb9

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/usb/ax88179_178a.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1273,6 +1273,8 @@ static void ax88179_get_mac_addr(struct usbnet *dev)
12731273

12741274
if (is_valid_ether_addr(mac)) {
12751275
eth_hw_addr_set(dev->net, mac);
1276+
if (!is_local_ether_addr(mac))
1277+
dev->net->addr_assign_type = NET_ADDR_PERM;
12761278
} else {
12771279
netdev_info(dev->net, "invalid MAC address, using random\n");
12781280
eth_hw_addr_random(dev->net);

0 commit comments

Comments
 (0)