Skip to content

Commit 2f0754f

Browse files
SiarheiVolkaubebarino
authored andcommitted
clk: jz4725b: fix mmc0 clock gating
The mmc0 clock gate bit was mistakenly assigned to "i2s" clock. You can find that the same bit is assigned to "mmc0" too. It leads to mmc0 hang for a long time after any sound activity also it prevented PM_SLEEP to work properly. I guess it was introduced by copy-paste from jz4740 driver where it is really controls I2S clock gate. Fixes: 226dfa4 ("clk: Add Ingenic jz4725b CGU driver") Signed-off-by: Siarhei Volkau <[email protected]> Tested-by: Siarhei Volkau <[email protected]> Reviewed-by: Paul Cercueil <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]>
1 parent 3494894 commit 2f0754f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/clk/ingenic/jz4725b-cgu.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,10 @@ static const struct ingenic_cgu_clk_info jz4725b_cgu_clocks[] = {
139139
},
140140

141141
[JZ4725B_CLK_I2S] = {
142-
"i2s", CGU_CLK_MUX | CGU_CLK_DIV | CGU_CLK_GATE,
142+
"i2s", CGU_CLK_MUX | CGU_CLK_DIV,
143143
.parents = { JZ4725B_CLK_EXT, JZ4725B_CLK_PLL_HALF, -1, -1 },
144144
.mux = { CGU_REG_CPCCR, 31, 1 },
145145
.div = { CGU_REG_I2SCDR, 0, 1, 9, -1, -1, -1 },
146-
.gate = { CGU_REG_CLKGR, 6 },
147146
},
148147

149148
[JZ4725B_CLK_SPI] = {

0 commit comments

Comments
 (0)