Skip to content

Commit 2f3c269

Browse files
julianwiedmanndavem330
authored andcommitted
s390/qeth: return proper errno on IO error
When propagating IO errors back to userspace, one error path in qeth_irq() currently returns '1' instead of a proper errno. Fixes: 54daaca ("s390/qeth: cancel cmd on early error") Signed-off-by: Julian Wiedmann <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c8183f5 commit 2f3c269

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/s390/net/qeth_core_main.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -901,30 +901,30 @@ static int qeth_get_problem(struct qeth_card *card, struct ccw_device *cdev,
901901
CCW_DEVID(cdev), dstat, cstat);
902902
print_hex_dump(KERN_WARNING, "qeth: irb ", DUMP_PREFIX_OFFSET,
903903
16, 1, irb, 64, 1);
904-
return 1;
904+
return -EIO;
905905
}
906906

907907
if (dstat & DEV_STAT_UNIT_CHECK) {
908908
if (sense[SENSE_RESETTING_EVENT_BYTE] &
909909
SENSE_RESETTING_EVENT_FLAG) {
910910
QETH_CARD_TEXT(card, 2, "REVIND");
911-
return 1;
911+
return -EIO;
912912
}
913913
if (sense[SENSE_COMMAND_REJECT_BYTE] &
914914
SENSE_COMMAND_REJECT_FLAG) {
915915
QETH_CARD_TEXT(card, 2, "CMDREJi");
916-
return 1;
916+
return -EIO;
917917
}
918918
if ((sense[2] == 0xaf) && (sense[3] == 0xfe)) {
919919
QETH_CARD_TEXT(card, 2, "AFFE");
920-
return 1;
920+
return -EIO;
921921
}
922922
if ((!sense[0]) && (!sense[1]) && (!sense[2]) && (!sense[3])) {
923923
QETH_CARD_TEXT(card, 2, "ZEROSEN");
924924
return 0;
925925
}
926926
QETH_CARD_TEXT(card, 2, "DGENCHK");
927-
return 1;
927+
return -EIO;
928928
}
929929
return 0;
930930
}

0 commit comments

Comments
 (0)