Skip to content

Commit 2fd22fa

Browse files
committed
firewire: core: record card index in tracepoints event for self ID sequence
This patch is for for-next branch. The selfIDComplete event occurs in the bus managed by one of 1394 OHCI controller in Linux system, while the existing tracepoints events has the lack of data about it to distinguish the issued hardware from the others. This commit adds card_index member into event structure to store the index of host controller in use, and prints it. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Sakamoto <[email protected]>
1 parent 67e5178 commit 2fd22fa

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

drivers/firewire/core-topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ static struct fw_node *build_tree(struct fw_card *card, const u32 *sid, int self
140140
}
141141

142142
port_capacity = self_id_sequence_get_port_capacity(quadlet_count);
143-
trace_self_id_sequence(self_id_sequence, quadlet_count, generation);
143+
trace_self_id_sequence(card->index, self_id_sequence, quadlet_count, generation);
144144

145145
for (port_index = 0; port_index < port_capacity; ++port_index) {
146146
port_status = self_id_sequence_get_port_status(self_id_sequence, quadlet_count,

include/trace/events/firewire.h

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -395,22 +395,25 @@ void copy_port_status(u8 *port_status, unsigned int port_capacity, const u32 *se
395395
unsigned int quadlet_count);
396396

397397
TRACE_EVENT(self_id_sequence,
398-
TP_PROTO(const u32 *self_id_sequence, unsigned int quadlet_count, unsigned int generation),
399-
TP_ARGS(self_id_sequence, quadlet_count, generation),
398+
TP_PROTO(unsigned int card_index, const u32 *self_id_sequence, unsigned int quadlet_count, unsigned int generation),
399+
TP_ARGS(card_index, self_id_sequence, quadlet_count, generation),
400400
TP_STRUCT__entry(
401+
__field(u8, card_index)
401402
__field(u8, generation)
402403
__dynamic_array(u8, port_status, self_id_sequence_get_port_capacity(quadlet_count))
403404
__dynamic_array(u32, self_id_sequence, quadlet_count)
404405
),
405406
TP_fast_assign(
407+
__entry->card_index = card_index;
406408
__entry->generation = generation;
407409
copy_port_status(__get_dynamic_array(port_status), __get_dynamic_array_len(port_status),
408410
self_id_sequence, quadlet_count);
409411
memcpy(__get_dynamic_array(self_id_sequence), self_id_sequence,
410412
__get_dynamic_array_len(self_id_sequence));
411413
),
412414
TP_printk(
413-
"generation=%u phy_id=0x%02x link_active=%s gap_count=%u scode=%u contender=%s power_class=%u initiated_reset=%s port_status=%s self_id_sequence=%s",
415+
"card_index=%u generation=%u phy_id=0x%02x link_active=%s gap_count=%u scode=%u contender=%s power_class=%u initiated_reset=%s port_status=%s self_id_sequence=%s",
416+
__entry->card_index,
414417
__entry->generation,
415418
PHY_PACKET_SELF_ID_GET_PHY_ID(__get_dynamic_array(self_id_sequence)),
416419
PHY_PACKET_SELF_ID_GET_LINK_ACTIVE(__get_dynamic_array(self_id_sequence)) ? "true" : "false",

0 commit comments

Comments
 (0)