Skip to content

Commit 2fe34d2

Browse files
kyoungho-kootytso
authored andcommitted
ext4: remove unused parameter of ext4_generic_delete_entry function
The ext4_generic_delete_entry function does not use the parameter handle, so it can be removed. Signed-off-by: Kyoungho Koo <[email protected]> Reviewed-by: Ritesh Harjani <[email protected]> Link: https://lore.kernel.org/r/20200810080701.GA14160@koo-Z370-HD3 Signed-off-by: Theodore Ts'o <[email protected]>
1 parent e0d438c commit 2fe34d2

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

fs/ext4/ext4.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2802,8 +2802,7 @@ extern int ext4_search_dir(struct buffer_head *bh,
28022802
struct ext4_filename *fname,
28032803
unsigned int offset,
28042804
struct ext4_dir_entry_2 **res_dir);
2805-
extern int ext4_generic_delete_entry(handle_t *handle,
2806-
struct inode *dir,
2805+
extern int ext4_generic_delete_entry(struct inode *dir,
28072806
struct ext4_dir_entry_2 *de_del,
28082807
struct buffer_head *bh,
28092808
void *entry_buf,

fs/ext4/inline.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1706,7 +1706,7 @@ int ext4_delete_inline_entry(handle_t *handle,
17061706
if (err)
17071707
goto out;
17081708

1709-
err = ext4_generic_delete_entry(handle, dir, de_del, bh,
1709+
err = ext4_generic_delete_entry(dir, de_del, bh,
17101710
inline_start, inline_size, 0);
17111711
if (err)
17121712
goto out;

fs/ext4/namei.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2465,8 +2465,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
24652465
* ext4_generic_delete_entry deletes a directory entry by merging it
24662466
* with the previous entry
24672467
*/
2468-
int ext4_generic_delete_entry(handle_t *handle,
2469-
struct inode *dir,
2468+
int ext4_generic_delete_entry(struct inode *dir,
24702469
struct ext4_dir_entry_2 *de_del,
24712470
struct buffer_head *bh,
24722471
void *entry_buf,
@@ -2527,8 +2526,7 @@ static int ext4_delete_entry(handle_t *handle,
25272526
if (unlikely(err))
25282527
goto out;
25292528

2530-
err = ext4_generic_delete_entry(handle, dir, de_del,
2531-
bh, bh->b_data,
2529+
err = ext4_generic_delete_entry(dir, de_del, bh, bh->b_data,
25322530
dir->i_sb->s_blocksize, csum_size);
25332531
if (err)
25342532
goto out;

0 commit comments

Comments
 (0)