xfs: free xfs_attrd_log_items correctly

Darrick J. Wong · dchinner · commit 2fe3ffcf5592 · 2022-05-20T14:42:49.000+10:00
Technically speaking, objects allocated out of a specific slab cache are
supposed to be freed to that slab cache.  The popular slab backends will
take care of this for us, but SLOB famously doesn't.  Fix this, even if
slob + xfs are not that common of a combination.

Signed-off-by: Darrick J. Wong &lt;djwong@kernel.org&gt;
Reviewed-by: Dave Chinner &lt;dchinner@redhat.com&gt;
Reviewed-by: Allison Henderson &lt;allison.henderson@oracle.com&gt;
Signed-off-by: Dave Chinner &lt;david@fromorbit.com&gt;
diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
@@ -233,7 +233,7 @@ STATIC void
 xfs_attrd_item_free(struct xfs_attrd_log_item *attrdp)
 {
 	kmem_free(attrdp->attrd_item.li_lv_shadow);
-	kmem_free(attrdp);
+	kmem_cache_free(xfs_attrd_cache, attrdp);
 }
 
 STATIC void

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ STATIC void`
`233`	`233`	`xfs_attrd_item_free(struct xfs_attrd_log_item *attrdp)`
`234`	`234`	`{`
`235`	`235`	`kmem_free(attrdp->attrd_item.li_lv_shadow);`
`236`		`- kmem_free(attrdp);`
	`236`	`+ kmem_cache_free(xfs_attrd_cache, attrdp);`
`237`	`237`	`}`
`238`	`238`
`239`	`239`	`STATIC void`