Skip to content

Commit 3034749

Browse files
Jeff Johnsonakpm00
authored andcommitted
KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko
make allmodconfig && make W=1 C=1 reports for lib/test_*.ko: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hexdump.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_dhry.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_firmware.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sysctl.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hash.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ida.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_list_sort.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_min_heap.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_module.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sort.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_keys.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_key_base.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_memcat_p.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_blackhole_dev.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_meminit.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_free_pages.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kprobes.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ref_tracker.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bits.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Jeff Johnson <[email protected]> Reviewed-by: Kees Cook <[email protected]> Reviewed-by: Masami Hiramatsu (Google) <[email protected]> Cc: Anil S Keshavamurthy <[email protected]> Cc: "David S. Miller" <[email protected]> Cc: Masami Hiramatsu (Google) <[email protected]> Cc: "Naveen N. Rao" <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent d2917ff commit 3034749

20 files changed

+22
-2
lines changed

lib/dhry_run.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,5 @@ static int __init dhry_init(void)
8383
module_init(dhry_init);
8484

8585
MODULE_AUTHOR("Geert Uytterhoeven <[email protected]>");
86+
MODULE_DESCRIPTION("Dhrystone benchmark test module");
8687
MODULE_LICENSE("GPL");

lib/test-kstrtox.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -732,4 +732,5 @@ static int __init test_kstrtox_init(void)
732732
return -EINVAL;
733733
}
734734
module_init(test_kstrtox_init);
735+
MODULE_DESCRIPTION("Module test for kstrto*() APIs");
735736
MODULE_LICENSE("Dual BSD/GPL");

lib/test_bits.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,4 +72,5 @@ static struct kunit_suite bits_test_suite = {
7272
};
7373
kunit_test_suite(bits_test_suite);
7474

75+
MODULE_DESCRIPTION("Test cases for functions and macros in bits.h");
7576
MODULE_LICENSE("GPL");

lib/test_blackhole_dev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ module_init(test_blackholedev_init);
9696
module_exit(test_blackholedev_exit);
9797

9898
MODULE_AUTHOR("Mahesh Bandewar <[email protected]>");
99+
MODULE_DESCRIPTION("module test of the blackhole_dev");
99100
MODULE_LICENSE("GPL");

lib/test_firmware.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1567,4 +1567,5 @@ static void __exit test_firmware_exit(void)
15671567
module_exit(test_firmware_exit);
15681568

15691569
MODULE_AUTHOR("Kees Cook <[email protected]>");
1570+
MODULE_DESCRIPTION("interface to trigger and test firmware loading");
15701571
MODULE_LICENSE("GPL");

lib/test_free_pages.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,5 @@ static void m_ex(void)
4444
module_init(m_in);
4545
module_exit(m_ex);
4646
MODULE_AUTHOR("Matthew Wilcox <[email protected]>");
47+
MODULE_DESCRIPTION("Check that free_pages() doesn't leak memory");
4748
MODULE_LICENSE("GPL");

lib/test_hash.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,4 +235,5 @@ static struct kunit_suite hash_test_suite = {
235235

236236
kunit_test_suite(hash_test_suite);
237237

238+
MODULE_DESCRIPTION("Test cases for <linux/hash.h> and <linux/stringhash.h>");
238239
MODULE_LICENSE("GPL");

lib/test_hexdump.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,4 +253,5 @@ static void __exit test_hexdump_exit(void)
253253
module_exit(test_hexdump_exit);
254254

255255
MODULE_AUTHOR("Andy Shevchenko <[email protected]>");
256+
MODULE_DESCRIPTION("Test cases for lib/hexdump.c module");
256257
MODULE_LICENSE("Dual BSD/GPL");

lib/test_ida.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,4 +214,5 @@ static void ida_exit(void)
214214
module_init(ida_checks);
215215
module_exit(ida_exit);
216216
MODULE_AUTHOR("Matthew Wilcox <[email protected]>");
217+
MODULE_DESCRIPTION("Test the IDA API");
217218
MODULE_LICENSE("GPL");

lib/test_kprobes.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// SPDX-License-Identifier: GPL-2.0-or-later
22
/*
3-
* test_kprobes.c - simple sanity test for *probes
3+
* test_kprobes.c - simple sanity test for k*probes
44
*
55
* Copyright IBM Corp. 2008
66
*/
@@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_suite = {
400400

401401
kunit_test_suites(&kprobes_test_suite);
402402

403+
MODULE_DESCRIPTION("simple sanity test for k*probes");
403404
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)