Skip to content

Commit 307ed94

Browse files
memcontrol.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]>
1 parent 859b494 commit 307ed94

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/linux/memcontrol.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ struct lruvec_stat {
106106
*/
107107
struct memcg_shrinker_map {
108108
struct rcu_head rcu;
109-
unsigned long map[0];
109+
unsigned long map[];
110110
};
111111

112112
/*
@@ -148,7 +148,7 @@ struct mem_cgroup_threshold_ary {
148148
/* Size of entries[] */
149149
unsigned int size;
150150
/* Array of thresholds */
151-
struct mem_cgroup_threshold entries[0];
151+
struct mem_cgroup_threshold entries[];
152152
};
153153

154154
struct mem_cgroup_thresholds {

0 commit comments

Comments
 (0)