Skip to content

Commit 30bb557

Browse files
committed
Merge tag 'ktest-v5.6' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest
Pull Ktest fixes and clean ups from Steven Rostedt: - Make the default option oldconfig instead of randconfig (one too many times I lost my config because I left the build type out) - Add timeout to ssh sync to sync before reboot (prevents test hangs) - A couple of spelling fix patches * tag 'ktest-v5.6' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest: ktest: Fix typos in ktest.pl ktest: Add timeout for ssh sync testing ktest: Make default build option oldconfig not randconfig ktest: Fix some typos in sample.conf
2 parents d397a82 + 1091c8f commit 30bb557

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

tools/testing/ktest/ktest.pl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"EMAIL_WHEN_STARTED" => 0,
3131
"NUM_TESTS" => 1,
3232
"TEST_TYPE" => "build",
33-
"BUILD_TYPE" => "randconfig",
33+
"BUILD_TYPE" => "oldconfig",
3434
"MAKE_CMD" => "make",
3535
"CLOSE_CONSOLE_SIGNAL" => "INT",
3636
"TIMEOUT" => 120,
@@ -1030,7 +1030,7 @@ sub __read_config {
10301030
}
10311031

10321032
if (!$skip && $rest !~ /^\s*$/) {
1033-
die "$name: $.: Gargbage found after $type\n$_";
1033+
die "$name: $.: Garbage found after $type\n$_";
10341034
}
10351035

10361036
if ($skip && $type eq "TEST_START") {
@@ -1063,7 +1063,7 @@ sub __read_config {
10631063
}
10641064

10651065
if ($rest !~ /^\s*$/) {
1066-
die "$name: $.: Gargbage found after DEFAULTS\n$_";
1066+
die "$name: $.: Garbage found after DEFAULTS\n$_";
10671067
}
10681068

10691069
} elsif (/^\s*INCLUDE\s+(\S+)/) {
@@ -1154,7 +1154,7 @@ sub __read_config {
11541154
# on of these sections that have SKIP defined.
11551155
# The save variable can be
11561156
# defined multiple times and the new one simply overrides
1157-
# the prevous one.
1157+
# the previous one.
11581158
set_variable($lvalue, $rvalue);
11591159

11601160
} else {
@@ -1234,7 +1234,7 @@ sub read_config {
12341234
foreach my $option (keys %not_used) {
12351235
print "$option\n";
12361236
}
1237-
print "Set IGRNORE_UNUSED = 1 to have ktest ignore unused variables\n";
1237+
print "Set IGNORE_UNUSED = 1 to have ktest ignore unused variables\n";
12381238
if (!read_yn "Do you want to continue?") {
12391239
exit -1;
12401240
}
@@ -1345,7 +1345,7 @@ sub eval_option {
13451345
# Check for recursive evaluations.
13461346
# 100 deep should be more than enough.
13471347
if ($r++ > 100) {
1348-
die "Over 100 evaluations accurred with $option\n" .
1348+
die "Over 100 evaluations occurred with $option\n" .
13491349
"Check for recursive variables\n";
13501350
}
13511351
$prev = $option;
@@ -1383,7 +1383,7 @@ sub reboot {
13831383

13841384
} else {
13851385
# Make sure everything has been written to disk
1386-
run_ssh("sync");
1386+
run_ssh("sync", 10);
13871387

13881388
if (defined($time)) {
13891389
start_monitor;
@@ -1461,7 +1461,7 @@ ()
14611461

14621462
sub dodie {
14631463

1464-
# avoid recusion
1464+
# avoid recursion
14651465
return if ($in_die);
14661466
$in_die = 1;
14671467

tools/testing/ktest/sample.conf

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#
1111

1212
# Options set in the beginning of the file are considered to be
13-
# default options. These options can be overriden by test specific
13+
# default options. These options can be overridden by test specific
1414
# options, with the following exceptions:
1515
#
1616
# LOG_FILE
@@ -204,7 +204,7 @@
204204
#
205205
# This config file can also contain "config variables".
206206
# These are assigned with ":=" instead of the ktest option
207-
# assigment "=".
207+
# assignment "=".
208208
#
209209
# The difference between ktest options and config variables
210210
# is that config variables can be used multiple times,
@@ -263,7 +263,7 @@
263263
#### Using options in other options ####
264264
#
265265
# Options that are defined in the config file may also be used
266-
# by other options. All options are evaulated at time of
266+
# by other options. All options are evaluated at time of
267267
# use (except that config variables are evaluated at config
268268
# processing time).
269269
#
@@ -505,7 +505,7 @@
505505
#TEST = ssh user@machine /root/run_test
506506

507507
# The build type is any make config type or special command
508-
# (default randconfig)
508+
# (default oldconfig)
509509
# nobuild - skip the clean and build step
510510
# useconfig:/path/to/config - use the given config and run
511511
# oldconfig on it.
@@ -707,7 +707,7 @@
707707

708708
# Line to define a successful boot up in console output.
709709
# This is what the line contains, not the entire line. If you need
710-
# the entire line to match, then use regural expression syntax like:
710+
# the entire line to match, then use regular expression syntax like:
711711
# (do not add any quotes around it)
712712
#
713713
# SUCCESS_LINE = ^MyBox Login:$
@@ -839,7 +839,7 @@
839839
# (ignored if POWEROFF_ON_SUCCESS is set)
840840
#REBOOT_ON_SUCCESS = 1
841841

842-
# In case there are isses with rebooting, you can specify this
842+
# In case there are issues with rebooting, you can specify this
843843
# to always powercycle after this amount of time after calling
844844
# reboot.
845845
# Note, POWERCYCLE_AFTER_REBOOT = 0 does NOT disable it. It just
@@ -848,7 +848,7 @@
848848
# (default undefined)
849849
#POWERCYCLE_AFTER_REBOOT = 5
850850

851-
# In case there's isses with halting, you can specify this
851+
# In case there's issues with halting, you can specify this
852852
# to always poweroff after this amount of time after calling
853853
# halt.
854854
# Note, POWEROFF_AFTER_HALT = 0 does NOT disable it. It just
@@ -972,7 +972,7 @@
972972
#
973973
# PATCHCHECK_START is required and is the first patch to
974974
# test (the SHA1 of the commit). You may also specify anything
975-
# that git checkout allows (branch name, tage, HEAD~3).
975+
# that git checkout allows (branch name, tag, HEAD~3).
976976
#
977977
# PATCHCHECK_END is the last patch to check (default HEAD)
978978
#
@@ -994,7 +994,7 @@
994994
# IGNORE_WARNINGS is set for the given commit's sha1
995995
#
996996
# IGNORE_WARNINGS can be used to disable the failure of patchcheck
997-
# on a particuler commit (SHA1). You can add more than one commit
997+
# on a particular commit (SHA1). You can add more than one commit
998998
# by adding a list of SHA1s that are space delimited.
999999
#
10001000
# If BUILD_NOCLEAN is set, then make mrproper will not be run on
@@ -1093,7 +1093,7 @@
10931093
# whatever reason. (Can't reboot, want to inspect each iteration)
10941094
# Doing a BISECT_MANUAL will have the test wait for you to
10951095
# tell it if the test passed or failed after each iteration.
1096-
# This is basicall the same as running git bisect yourself
1096+
# This is basically the same as running git bisect yourself
10971097
# but ktest will rebuild and install the kernel for you.
10981098
#
10991099
# BISECT_CHECK = 1 (optional, default 0)
@@ -1239,7 +1239,7 @@
12391239
#
12401240
# CONFIG_BISECT_EXEC (optional)
12411241
# The config bisect is a separate program that comes with ktest.pl.
1242-
# By befault, it will look for:
1242+
# By default, it will look for:
12431243
# `pwd`/config-bisect.pl # the location ktest.pl was executed from.
12441244
# If it does not find it there, it will look for:
12451245
# `dirname <ktest.pl>`/config-bisect.pl # The directory that holds ktest.pl

0 commit comments

Comments
 (0)