Skip to content

Commit 30ca9b0

Browse files
Anson-HuangShawn Guo
authored andcommitted
soc: imx: imx-scu: Getting UID from SCU should have response
The SCU firmware API for getting UID should have response, otherwise, the message stored in function stack could be released and then the response data received from SCU will be stored into that released stack and cause kernel NULL pointer dump. Fixes: 73feb4d ("soc: imx-scu: Add SoC UID(unique identifier) support") Signed-off-by: Anson Huang <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent 54ecb8f commit 30ca9b0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/soc/imx/soc-imx-scu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ static ssize_t soc_uid_show(struct device *dev,
4646
hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
4747
hdr->size = 1;
4848

49-
ret = imx_scu_call_rpc(soc_ipc_handle, &msg, false);
49+
ret = imx_scu_call_rpc(soc_ipc_handle, &msg, true);
5050
if (ret) {
5151
pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);
5252
return ret;

0 commit comments

Comments
 (0)