ASoC: tas2562: Return invalid for when bitwidth is invalid

Dan Murphy · broonie · commit 310006cab991 · 2020-02-18T20:29:08.000Z
If the bitwidth passed in to the set_bitwidth function is not supported then return an error. Fixes: 29b74236bd57 ("ASoC: tas2562: Introduce the TAS2562 amplifier") Signed-off-by: Dan Murphy <dmurphy@ti.com> Link: https://lore.kernel.org/r/20200218185252.26290-1-dmurphy@ti.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
@@ -215,7 +215,8 @@ static int tas2562_set_bitwidth(struct tas2562_data *tas2562, int bitwidth)
 		break;
 
 	default:
-		dev_info(tas2562->dev, "Not supported params format\n");
+		dev_info(tas2562->dev, "Unsupported bitwidth format\n");
+		return -EINVAL;
 	}
 
 	ret = snd_soc_component_update_bits(tas2562->component,

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,8 @@ static int tas2562_set_bitwidth(struct tas2562_data *tas2562, int bitwidth)`
`215`	`215`	`break;`
`216`	`216`
`217`	`217`	`default:`
`218`		`- dev_info(tas2562->dev, "Not supported params format\n");`
	`218`	`+ dev_info(tas2562->dev, "Unsupported bitwidth format\n");`
	`219`	`+ return -EINVAL;`
`219`	`220`	`}`
`220`	`221`
`221`	`222`	`ret = snd_soc_component_update_bits(tas2562->component,`