Skip to content

Commit 31168f0

Browse files
rpptpaulburton
authored andcommitted
mips: drop __pXd_offset() macros that duplicate pXd_index() ones
The __pXd_offset() macros are identical to the pXd_index() macros and there is no point to keep both of them. All architectures define and use pXd_index() so let's keep only those to make mips consistent with the rest of the kernel. Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Paul Burton <[email protected]> Cc: Ralf Baechle <[email protected]> Cc: James Hogan <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: Mike Rapoport <[email protected]>
1 parent 3ed6751 commit 31168f0

File tree

6 files changed

+18
-25
lines changed

6 files changed

+18
-25
lines changed

arch/mips/include/asm/pgtable-32.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,14 +196,11 @@ static inline pte_t pfn_pte(unsigned long pfn, pgprot_t prot)
196196

197197
#define pte_page(x) pfn_to_page(pte_pfn(x))
198198

199-
#define __pgd_offset(address) pgd_index(address)
200-
#define __pud_offset(address) (((address) >> PUD_SHIFT) & (PTRS_PER_PUD-1))
201-
#define __pmd_offset(address) (((address) >> PMD_SHIFT) & (PTRS_PER_PMD-1))
202-
203199
/* to find an entry in a kernel page-table-directory */
204200
#define pgd_offset_k(address) pgd_offset(&init_mm, address)
205201

206202
#define pgd_index(address) (((address) >> PGDIR_SHIFT) & (PTRS_PER_PGD-1))
203+
#define pud_index(address) (((address) >> PUD_SHIFT) & (PTRS_PER_PUD-1))
207204
#define pmd_index(address) (((address) >> PMD_SHIFT) & (PTRS_PER_PMD-1))
208205

209206
/* to find an entry in a page-table-directory */

arch/mips/include/asm/pgtable-64.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -319,10 +319,6 @@ static inline void pud_clear(pud_t *pudp)
319319
#define pfn_pmd(pfn, prot) __pmd(((pfn) << _PFN_SHIFT) | pgprot_val(prot))
320320
#endif
321321

322-
#define __pgd_offset(address) pgd_index(address)
323-
#define __pud_offset(address) (((address) >> PUD_SHIFT) & (PTRS_PER_PUD-1))
324-
#define __pmd_offset(address) pmd_index(address)
325-
326322
/* to find an entry in a kernel page-table-directory */
327323
#define pgd_offset_k(address) pgd_offset(&init_mm, address)
328324

arch/mips/kvm/mmu.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ static bool kvm_mips_flush_gpa_pmd(pmd_t *pmd, unsigned long start_gpa,
204204
{
205205
pte_t *pte;
206206
unsigned long end = ~0ul;
207-
int i_min = __pmd_offset(start_gpa);
208-
int i_max = __pmd_offset(end_gpa);
207+
int i_min = pmd_index(start_gpa);
208+
int i_max = pmd_index(end_gpa);
209209
bool safe_to_remove = (i_min == 0 && i_max == PTRS_PER_PMD - 1);
210210
int i;
211211

@@ -232,8 +232,8 @@ static bool kvm_mips_flush_gpa_pud(pud_t *pud, unsigned long start_gpa,
232232
{
233233
pmd_t *pmd;
234234
unsigned long end = ~0ul;
235-
int i_min = __pud_offset(start_gpa);
236-
int i_max = __pud_offset(end_gpa);
235+
int i_min = pud_index(start_gpa);
236+
int i_max = pud_index(end_gpa);
237237
bool safe_to_remove = (i_min == 0 && i_max == PTRS_PER_PUD - 1);
238238
int i;
239239

@@ -334,8 +334,8 @@ static int kvm_mips_##name##_pmd(pmd_t *pmd, unsigned long start, \
334334
int ret = 0; \
335335
pte_t *pte; \
336336
unsigned long cur_end = ~0ul; \
337-
int i_min = __pmd_offset(start); \
338-
int i_max = __pmd_offset(end); \
337+
int i_min = pmd_index(start); \
338+
int i_max = pmd_index(end); \
339339
int i; \
340340
\
341341
for (i = i_min; i <= i_max; ++i, start = 0) { \
@@ -357,8 +357,8 @@ static int kvm_mips_##name##_pud(pud_t *pud, unsigned long start, \
357357
int ret = 0; \
358358
pmd_t *pmd; \
359359
unsigned long cur_end = ~0ul; \
360-
int i_min = __pud_offset(start); \
361-
int i_max = __pud_offset(end); \
360+
int i_min = pud_index(start); \
361+
int i_max = pud_index(end); \
362362
int i; \
363363
\
364364
for (i = i_min; i <= i_max; ++i, start = 0) { \
@@ -862,8 +862,8 @@ static bool kvm_mips_flush_gva_pmd(pmd_t *pmd, unsigned long start_gva,
862862
{
863863
pte_t *pte;
864864
unsigned long end = ~0ul;
865-
int i_min = __pmd_offset(start_gva);
866-
int i_max = __pmd_offset(end_gva);
865+
int i_min = pmd_index(start_gva);
866+
int i_max = pmd_index(end_gva);
867867
bool safe_to_remove = (i_min == 0 && i_max == PTRS_PER_PMD - 1);
868868
int i;
869869

@@ -890,8 +890,8 @@ static bool kvm_mips_flush_gva_pud(pud_t *pud, unsigned long start_gva,
890890
{
891891
pmd_t *pmd;
892892
unsigned long end = ~0ul;
893-
int i_min = __pud_offset(start_gva);
894-
int i_max = __pud_offset(end_gva);
893+
int i_min = pud_index(start_gva);
894+
int i_max = pud_index(end_gva);
895895
bool safe_to_remove = (i_min == 0 && i_max == PTRS_PER_PUD - 1);
896896
int i;
897897

arch/mips/mm/fault.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ static void __kprobes __do_page_fault(struct pt_regs *regs, unsigned long write,
292292
* Do _not_ use "tsk" here. We might be inside
293293
* an interrupt in the middle of a task switch..
294294
*/
295-
int offset = __pgd_offset(address);
295+
int offset = pgd_index(address);
296296
pgd_t *pgd, *pgd_k;
297297
pud_t *pud, *pud_k;
298298
pmd_t *pmd, *pmd_k;

arch/mips/mm/init.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -239,9 +239,9 @@ void __init fixrange_init(unsigned long start, unsigned long end,
239239
unsigned long vaddr;
240240

241241
vaddr = start;
242-
i = __pgd_offset(vaddr);
243-
j = __pud_offset(vaddr);
244-
k = __pmd_offset(vaddr);
242+
i = pgd_index(vaddr);
243+
j = pud_index(vaddr);
244+
k = pmd_index(vaddr);
245245
pgd = pgd_base + i;
246246

247247
for ( ; (i < PTRS_PER_PGD) && (vaddr < end); pgd++, i++) {

arch/mips/mm/pgtable-32.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ void __init pagetable_init(void)
8181
vaddr = PKMAP_BASE;
8282
fixrange_init(vaddr & PMD_MASK, vaddr + PAGE_SIZE*LAST_PKMAP, pgd_base);
8383

84-
pgd = swapper_pg_dir + __pgd_offset(vaddr);
84+
pgd = swapper_pg_dir + pgd_index(vaddr);
8585
pud = pud_offset(pgd, vaddr);
8686
pmd = pmd_offset(pud, vaddr);
8787
pte = pte_offset_kernel(pmd, vaddr);

0 commit comments

Comments
 (0)