Skip to content

Commit 3137b83

Browse files
arndbdamien-lemoal
authored andcommitted
ata: sata_mv: Fix PCI device ID table declaration compilation warning
Building with W=1 shows a warning for an unused variable when CONFIG_PCI is diabled: drivers/ata/sata_mv.c:790:35: error: unused variable 'mv_pci_tbl' [-Werror,-Wunused-const-variable] static const struct pci_device_id mv_pci_tbl[] = { Move the table into the same block that containsn the pci_driver definition. Fixes: 7bb3c52 ("sata_mv: Remove PCI dependency") Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Damien Le Moal <[email protected]>
1 parent c88b50a commit 3137b83

File tree

1 file changed

+31
-32
lines changed

1 file changed

+31
-32
lines changed

drivers/ata/sata_mv.c

Lines changed: 31 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -787,37 +787,6 @@ static const struct ata_port_info mv_port_info[] = {
787787
},
788788
};
789789

790-
static const struct pci_device_id mv_pci_tbl[] = {
791-
{ PCI_VDEVICE(MARVELL, 0x5040), chip_504x },
792-
{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
793-
{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
794-
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
795-
/* RocketRAID 1720/174x have different identifiers */
796-
{ PCI_VDEVICE(TTI, 0x1720), chip_6042 },
797-
{ PCI_VDEVICE(TTI, 0x1740), chip_6042 },
798-
{ PCI_VDEVICE(TTI, 0x1742), chip_6042 },
799-
800-
{ PCI_VDEVICE(MARVELL, 0x6040), chip_604x },
801-
{ PCI_VDEVICE(MARVELL, 0x6041), chip_604x },
802-
{ PCI_VDEVICE(MARVELL, 0x6042), chip_6042 },
803-
{ PCI_VDEVICE(MARVELL, 0x6080), chip_608x },
804-
{ PCI_VDEVICE(MARVELL, 0x6081), chip_608x },
805-
806-
{ PCI_VDEVICE(ADAPTEC2, 0x0241), chip_604x },
807-
808-
/* Adaptec 1430SA */
809-
{ PCI_VDEVICE(ADAPTEC2, 0x0243), chip_7042 },
810-
811-
/* Marvell 7042 support */
812-
{ PCI_VDEVICE(MARVELL, 0x7042), chip_7042 },
813-
814-
/* Highpoint RocketRAID PCIe series */
815-
{ PCI_VDEVICE(TTI, 0x2300), chip_7042 },
816-
{ PCI_VDEVICE(TTI, 0x2310), chip_7042 },
817-
818-
{ } /* terminate list */
819-
};
820-
821790
static const struct mv_hw_ops mv5xxx_ops = {
822791
.phy_errata = mv5_phy_errata,
823792
.enable_leds = mv5_enable_leds,
@@ -4303,6 +4272,36 @@ static int mv_pci_init_one(struct pci_dev *pdev,
43034272
static int mv_pci_device_resume(struct pci_dev *pdev);
43044273
#endif
43054274

4275+
static const struct pci_device_id mv_pci_tbl[] = {
4276+
{ PCI_VDEVICE(MARVELL, 0x5040), chip_504x },
4277+
{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
4278+
{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
4279+
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
4280+
/* RocketRAID 1720/174x have different identifiers */
4281+
{ PCI_VDEVICE(TTI, 0x1720), chip_6042 },
4282+
{ PCI_VDEVICE(TTI, 0x1740), chip_6042 },
4283+
{ PCI_VDEVICE(TTI, 0x1742), chip_6042 },
4284+
4285+
{ PCI_VDEVICE(MARVELL, 0x6040), chip_604x },
4286+
{ PCI_VDEVICE(MARVELL, 0x6041), chip_604x },
4287+
{ PCI_VDEVICE(MARVELL, 0x6042), chip_6042 },
4288+
{ PCI_VDEVICE(MARVELL, 0x6080), chip_608x },
4289+
{ PCI_VDEVICE(MARVELL, 0x6081), chip_608x },
4290+
4291+
{ PCI_VDEVICE(ADAPTEC2, 0x0241), chip_604x },
4292+
4293+
/* Adaptec 1430SA */
4294+
{ PCI_VDEVICE(ADAPTEC2, 0x0243), chip_7042 },
4295+
4296+
/* Marvell 7042 support */
4297+
{ PCI_VDEVICE(MARVELL, 0x7042), chip_7042 },
4298+
4299+
/* Highpoint RocketRAID PCIe series */
4300+
{ PCI_VDEVICE(TTI, 0x2300), chip_7042 },
4301+
{ PCI_VDEVICE(TTI, 0x2310), chip_7042 },
4302+
4303+
{ } /* terminate list */
4304+
};
43064305

43074306
static struct pci_driver mv_pci_driver = {
43084307
.name = DRV_NAME,
@@ -4315,6 +4314,7 @@ static struct pci_driver mv_pci_driver = {
43154314
#endif
43164315

43174316
};
4317+
MODULE_DEVICE_TABLE(pci, mv_pci_tbl);
43184318

43194319
/**
43204320
* mv_print_info - Dump key info to kernel log for perusal.
@@ -4487,7 +4487,6 @@ static void __exit mv_exit(void)
44874487
MODULE_AUTHOR("Brett Russ");
44884488
MODULE_DESCRIPTION("SCSI low-level driver for Marvell SATA controllers");
44894489
MODULE_LICENSE("GPL v2");
4490-
MODULE_DEVICE_TABLE(pci, mv_pci_tbl);
44914490
MODULE_VERSION(DRV_VERSION);
44924491
MODULE_ALIAS("platform:" DRV_NAME);
44934492

0 commit comments

Comments
 (0)