Skip to content

Commit 32373aa

Browse files
committed
drm/i915/dpio: Clean up VLV/CHV DPIO PHY register defines
The DPIO PHY registers follow clear numbering rules. Express those in a few macros to get rid of the hand calculated final offsets. Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Jani Nikula <[email protected]>
1 parent 61f73e8 commit 32373aa

File tree

2 files changed

+101
-176
lines changed

2 files changed

+101
-176
lines changed

drivers/gpu/drm/i915/display/intel_dpio_phy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1078,7 +1078,7 @@ void vlv_set_phy_signal_level(struct intel_encoder *encoder,
10781078
vlv_dpio_write(dev_priv, phy, VLV_TX_DW3_GRP(ch), 0x0C782040);
10791079

10801080
if (tx3_demph)
1081-
vlv_dpio_write(dev_priv, phy, VLV_TX3_DW4(ch), tx3_demph);
1081+
vlv_dpio_write(dev_priv, phy, VLV_TX_DW4(ch, 3), tx3_demph);
10821082

10831083
vlv_dpio_write(dev_priv, phy, VLV_PCS_DW11_GRP(ch), 0x00030000);
10841084
vlv_dpio_write(dev_priv, phy, VLV_PCS_DW9_GRP(ch), preemph_reg_value);

0 commit comments

Comments
 (0)