Skip to content

Commit 3268a4d

Browse files
Jiapeng Chongsre
authored andcommitted
power: supply: rk817: Fix unsigned comparison with less than zero
The tmp is defined as u32 type, which results in invalid processing of tmp<0 in function rk817_read_or_set_full_charge_on_boot(). Therefore, drop the comparison. drivers/power/supply/rk817_charger.c:828 rk817_read_or_set_full_charge_on_boot() warn: unsigned 'tmp' is never less than zero. drivers/power/supply/rk817_charger.c:788 rk817_read_or_set_full_charge_on_boot() warn: unsigned 'tmp' is never less than zero. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3444 Reported-by: Abaci Robot <[email protected]> Signed-off-by: Jiapeng Chong <[email protected]> Tested-by: Chris Morgan <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]>
1 parent fe15c26 commit 3268a4d

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/power/supply/rk817_charger.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -785,8 +785,6 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger,
785785
regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_Q_PRES_H3,
786786
bulk_reg, 4);
787787
tmp = get_unaligned_be32(bulk_reg);
788-
if (tmp < 0)
789-
tmp = 0;
790788
boot_charge_mah = ADC_TO_CHARGE_UAH(tmp,
791789
charger->res_div) / 1000;
792790
/*
@@ -825,8 +823,6 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger,
825823
regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_Q_PRES_H3,
826824
bulk_reg, 4);
827825
tmp = get_unaligned_be32(bulk_reg);
828-
if (tmp < 0)
829-
tmp = 0;
830826
boot_charge_mah = ADC_TO_CHARGE_UAH(tmp, charger->res_div) / 1000;
831827
regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_OCV_VOL_H,
832828
bulk_reg, 2);

0 commit comments

Comments
 (0)