Skip to content

Commit 32818c0

Browse files
congwangdavem330
authored andcommitted
geneve: fix an uninitialized value in geneve_changelink()
geneve_nl2info() sets 'df' conditionally, so we have to initialize it by copying the value from existing geneve device in geneve_changelink(). Fixes: 56c09de ("geneve: allow changing DF behavior after creation") Reported-by: [email protected] Cc: Sabrina Dubroca <[email protected]> Signed-off-by: Cong Wang <[email protected]> Reviewed-by: Sabrina Dubroca <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c75d1d5 commit 32818c0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/geneve.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1615,11 +1615,11 @@ static int geneve_changelink(struct net_device *dev, struct nlattr *tb[],
16151615
struct netlink_ext_ack *extack)
16161616
{
16171617
struct geneve_dev *geneve = netdev_priv(dev);
1618+
enum ifla_geneve_df df = geneve->df;
16181619
struct geneve_sock *gs4, *gs6;
16191620
struct ip_tunnel_info info;
16201621
bool metadata;
16211622
bool use_udp6_rx_checksums;
1622-
enum ifla_geneve_df df;
16231623
bool ttl_inherit;
16241624
int err;
16251625

0 commit comments

Comments
 (0)