Skip to content

Commit 32a4781

Browse files
rddunlaphtejun
authored andcommitted
cgroup/cpuset: fix a few kernel-doc warnings & coding style
Fix kernel-doc notation warnings: kernel/cgroup/cpuset.c:1309: warning: Excess function parameter 'cpuset' description in 'update_parent_subparts_cpumask' kernel/cgroup/cpuset.c:3909: warning: expecting prototype for cpuset_mem_spread_node(). Prototype was for cpuset_spread_node() instead Also drop a blank line before EXPORT_SYMBOL_GPL() to be consistent with kernel coding style. Signed-off-by: Randy Dunlap <[email protected]> Cc: Waiman Long <[email protected]> Cc: Zefan Li <[email protected]> Cc: Tejun Heo <[email protected]> Cc: Johannes Weiner <[email protected]> Cc: [email protected] Signed-off-by: Tejun Heo <[email protected]>
1 parent 980660c commit 32a4781

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

kernel/cgroup/cpuset.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1267,7 +1267,7 @@ static int update_flag(cpuset_flagbits_t bit, struct cpuset *cs,
12671267
int turning_on);
12681268
/**
12691269
* update_parent_subparts_cpumask - update subparts_cpus mask of parent cpuset
1270-
* @cpuset: The cpuset that requests change in partition root state
1270+
* @cs: The cpuset that requests change in partition root state
12711271
* @cmd: Partition root state change command
12721272
* @newmask: Optional new cpumask for partcmd_update
12731273
* @tmp: Temporary addmask and delmask
@@ -3877,8 +3877,7 @@ bool __cpuset_node_allowed(int node, gfp_t gfp_mask)
38773877
}
38783878

38793879
/**
3880-
* cpuset_mem_spread_node() - On which node to begin search for a file page
3881-
* cpuset_slab_spread_node() - On which node to begin search for a slab page
3880+
* cpuset_spread_node() - On which node to begin search for a page
38823881
*
38833882
* If a task is marked PF_SPREAD_PAGE or PF_SPREAD_SLAB (as for
38843883
* tasks in a cpuset with is_spread_page or is_spread_slab set),
@@ -3902,12 +3901,14 @@ bool __cpuset_node_allowed(int node, gfp_t gfp_mask)
39023901
* is passed an offline node, it will fall back to the local node.
39033902
* See kmem_cache_alloc_node().
39043903
*/
3905-
39063904
static int cpuset_spread_node(int *rotor)
39073905
{
39083906
return *rotor = next_node_in(*rotor, current->mems_allowed);
39093907
}
39103908

3909+
/**
3910+
* cpuset_mem_spread_node() - On which node to begin search for a file page
3911+
*/
39113912
int cpuset_mem_spread_node(void)
39123913
{
39133914
if (current->cpuset_mem_spread_rotor == NUMA_NO_NODE)
@@ -3917,6 +3918,9 @@ int cpuset_mem_spread_node(void)
39173918
return cpuset_spread_node(&current->cpuset_mem_spread_rotor);
39183919
}
39193920

3921+
/**
3922+
* cpuset_slab_spread_node() - On which node to begin search for a slab page
3923+
*/
39203924
int cpuset_slab_spread_node(void)
39213925
{
39223926
if (current->cpuset_slab_spread_rotor == NUMA_NO_NODE)
@@ -3925,7 +3929,6 @@ int cpuset_slab_spread_node(void)
39253929

39263930
return cpuset_spread_node(&current->cpuset_slab_spread_rotor);
39273931
}
3928-
39293932
EXPORT_SYMBOL_GPL(cpuset_mem_spread_node);
39303933

39313934
/**

0 commit comments

Comments
 (0)