Skip to content

Commit 32ec783

Browse files
arndbgregkh
authored andcommitted
firmware: imx: fix compile-testing
It is nice to allow compile-testing the firmware drivers, but this fails when the dependency is a loadable module: aarch64-linux-ld: drivers/firmware/imx/scu-pd.o: in function `imx_sc_pd_power': scu-pd.c:(.text+0xd8): undefined reference to `imx_scu_call_rpc' aarch64-linux-ld: scu-pd.c:(.text+0x108): undefined reference to `imx_scu_call_rpc' aarch64-linux-ld: drivers/firmware/imx/scu-pd.o: in function `imx_sc_pd_probe': Change the dependencies to ensure that any driver we depend on is either reachable or we are compile-testing and it is disabled, effectively reverting most of the previous changes that turned out to be incorrect. Fixes: a9f85f9 ("firmware: imx: add COMPILE_TEST support") Fixes: 5b00b83 ("firmware: imx: add COMPILE_TEST for IMX_SCU driver") Signed-off-by: Arnd Bergmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8f3d9f3 commit 32ec783

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/firmware/imx/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ config IMX_DSP
1212

1313
config IMX_SCU
1414
bool "IMX SCU Protocol driver"
15-
depends on IMX_MBOX || COMPILE_TEST
15+
depends on IMX_MBOX
1616
help
1717
The System Controller Firmware (SCFW) is a low-level system function
1818
which runs on a dedicated Cortex-M core to provide power, clock, and
@@ -24,6 +24,6 @@ config IMX_SCU
2424

2525
config IMX_SCU_PD
2626
bool "IMX SCU Power Domain driver"
27-
depends on IMX_SCU || COMPILE_TEST
27+
depends on IMX_SCU
2828
help
2929
The System Controller Firmware (SCFW) based power domain driver.

0 commit comments

Comments
 (0)