Skip to content

Commit 3309ca6

Browse files
johnhubbardhtejun
authored andcommitted
selftests/cgroup: cpu_hogger init: use {} instead of {NULL}
First of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via: make LLVM=1 -C tools/testing/selftests ...clang generates warning here, because struct cpu_hogger has multiple fields, and the code is initializing an array of these structs, and it is incorrect to specify a single NULL value as the initializer. Fix this by initializing with {}, so that the compiler knows to use default initializer values for all fields in each array entry. [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ Signed-off-by: John Hubbard <[email protected]> Reviewed-by: Roman Gushchin <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent 0515089 commit 3309ca6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/cgroup/test_cpu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ run_cpucg_weight_test(
237237
{
238238
int ret = KSFT_FAIL, i;
239239
char *parent = NULL;
240-
struct cpu_hogger children[3] = {NULL};
240+
struct cpu_hogger children[3] = {};
241241

242242
parent = cg_name(root, "cpucg_test_0");
243243
if (!parent)
@@ -408,7 +408,7 @@ run_cpucg_nested_weight_test(const char *root, bool overprovisioned)
408408
{
409409
int ret = KSFT_FAIL, i;
410410
char *parent = NULL, *child = NULL;
411-
struct cpu_hogger leaf[3] = {NULL};
411+
struct cpu_hogger leaf[3] = {};
412412
long nested_leaf_usage, child_usage;
413413
int nprocs = get_nprocs();
414414

0 commit comments

Comments
 (0)