Skip to content

Commit 3407d82

Browse files
committed
firmware: edd: remove empty default_attrs array
The default_attrs array of attributes for the edd sysfs entries is totally empty for some reason, and a list of attributes is added later after the object is created (which should be fixed up later as it's racy). Because this pointer is never used, and is empty, and we are trying to remove all default_attrs usages, just delete it. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent ab6d0f5 commit 3407d82

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

drivers/firmware/edd.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -574,14 +574,6 @@ static EDD_DEVICE_ATTR(interface, 0444, edd_show_interface, edd_has_edd30);
574574
static EDD_DEVICE_ATTR(host_bus, 0444, edd_show_host_bus, edd_has_edd30);
575575
static EDD_DEVICE_ATTR(mbr_signature, 0444, edd_show_mbr_signature, edd_has_mbr_signature);
576576

577-
578-
/* These are default attributes that are added for every edd
579-
* device discovered. There are none.
580-
*/
581-
static struct attribute * def_attrs[] = {
582-
NULL,
583-
};
584-
585577
/* These attributes are conditional and only added for some devices. */
586578
static struct edd_attribute * edd_attrs[] = {
587579
&edd_attr_raw_data,
@@ -619,7 +611,6 @@ static void edd_release(struct kobject * kobj)
619611
static struct kobj_type edd_ktype = {
620612
.release = edd_release,
621613
.sysfs_ops = &edd_attr_ops,
622-
.default_attrs = def_attrs,
623614
};
624615

625616
static struct kset *edd_kset;

0 commit comments

Comments
 (0)