Skip to content

Commit 344ea0d

Browse files
hcodinapH5
authored andcommitted
misc: lan966x_pci: Fix dtc warns 'missing or empty reg/ranges property'
dtc generates the following warnings when building the LAN966x device tree overlay (lan966x_pci.dtso): Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property Indeed, related nodes are under the pci-ep-bus (simple-bus) which is not correct. Put them outside this node. Reported-by: Stephen Rothwell <[email protected]> Closes: https://lore.kernel.org/all/[email protected]/ Fixes: 185686b ("misc: Add support for LAN966x PCI device") Signed-off-by: Herve Codina <[email protected]> Reviewed-by: Rob Herring (Arm) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Philipp Zabel <[email protected]>
1 parent 37b395c commit 344ea0d

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

drivers/misc/lan966x_pci.dtso

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,24 @@
1919
#address-cells = <3>;
2020
#size-cells = <2>;
2121

22+
cpu_clk: clock-600000000 {
23+
compatible = "fixed-clock";
24+
#clock-cells = <0>;
25+
clock-frequency = <600000000>; /* CPU clock = 600MHz */
26+
};
27+
28+
ddr_clk: clock-30000000 {
29+
compatible = "fixed-clock";
30+
#clock-cells = <0>;
31+
clock-frequency = <30000000>; /* Fabric clock = 30MHz */
32+
};
33+
34+
sys_clk: clock-15625000 {
35+
compatible = "fixed-clock";
36+
#clock-cells = <0>;
37+
clock-frequency = <15625000>; /* System clock = 15.625MHz */
38+
};
39+
2240
pci-ep-bus@0 {
2341
compatible = "simple-bus";
2442
#address-cells = <1>;
@@ -39,24 +57,6 @@
3957
reg = <0xe00c0120 0x190>;
4058
};
4159

42-
cpu_clk: cpu_clk {
43-
compatible = "fixed-clock";
44-
#clock-cells = <0>;
45-
clock-frequency = <600000000>; // CPU clock = 600MHz
46-
};
47-
48-
ddr_clk: ddr_clk {
49-
compatible = "fixed-clock";
50-
#clock-cells = <0>;
51-
clock-frequency = <30000000>; // Fabric clock = 30MHz
52-
};
53-
54-
sys_clk: sys_clk {
55-
compatible = "fixed-clock";
56-
#clock-cells = <0>;
57-
clock-frequency = <15625000>; // System clock = 15.625MHz
58-
};
59-
6060
cpu_ctrl: syscon@e00c0000 {
6161
compatible = "microchip,lan966x-cpu-syscon", "syscon";
6262
reg = <0xe00c0000 0xa8>;

0 commit comments

Comments
 (0)