Skip to content

Commit 3482030

Browse files
oleg-nesterovmhiramat
authored andcommitted
uprobes: fix kernel info leak via "[uprobes]" vma
xol_add_vma() maps the uninitialized page allocated by __create_xol_area() into userspace. On some architectures (x86) this memory is readable even without VM_READ, VM_EXEC results in the same pgprot_t as VM_EXEC|VM_READ, although this doesn't really matter, debugger can read this memory anyway. Link: https://lore.kernel.org/all/[email protected]/ Reported-by: Will Deacon <[email protected]> Fixes: d4b3b63 ("uprobes/core: Allocate XOL slots for uprobes use") Cc: [email protected] Acked-by: Masami Hiramatsu (Google) <[email protected]> Signed-off-by: Oleg Nesterov <[email protected]> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
1 parent ad46e8f commit 3482030

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/events/uprobes.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1545,7 +1545,7 @@ static struct xol_area *__create_xol_area(unsigned long vaddr)
15451545
if (!area->bitmap)
15461546
goto free_area;
15471547

1548-
area->page = alloc_page(GFP_HIGHUSER);
1548+
area->page = alloc_page(GFP_HIGHUSER | __GFP_ZERO);
15491549
if (!area->page)
15501550
goto free_bitmap;
15511551

0 commit comments

Comments
 (0)