Skip to content

Commit 34d7ecb

Browse files
Nikolay Aleksandrovdavem330
authored andcommitted
selftests: net: bridge: update IGMP/MLD membership interval value
When I fixed IGMPv3/MLDv2 to use the bridge's multicast_membership_interval value which is chosen by user-space instead of calculating it based on multicast_query_interval and multicast_query_response_interval I forgot to update the selftests relying on that behaviour. Now we have to manually set the expected GMI value to perform the tests correctly and get proper results (similar to IGMPv2 behaviour). Fixes: fac3cb8 ("net: bridge: mcast: use multicast_membership_interval for IGMPv3") Signed-off-by: Nikolay Aleksandrov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 829e050 commit 34d7ecb

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

tools/testing/selftests/net/forwarding/bridge_igmp.sh

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,10 +482,15 @@ v3exc_timeout_test()
482482
local X=("192.0.2.20" "192.0.2.30")
483483

484484
# GMI should be 3 seconds
485-
ip link set dev br0 type bridge mcast_query_interval 100 mcast_query_response_interval 100
485+
ip link set dev br0 type bridge mcast_query_interval 100 \
486+
mcast_query_response_interval 100 \
487+
mcast_membership_interval 300
486488

487489
v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP
488-
ip link set dev br0 type bridge mcast_query_interval 500 mcast_query_response_interval 500
490+
ip link set dev br0 type bridge mcast_query_interval 500 \
491+
mcast_query_response_interval 500 \
492+
mcast_membership_interval 1500
493+
489494
$MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW2" -q
490495
sleep 3
491496
bridge -j -d -s mdb show dev br0 \
@@ -517,7 +522,8 @@ v3exc_timeout_test()
517522
log_test "IGMPv3 group $TEST_GROUP exclude timeout"
518523

519524
ip link set dev br0 type bridge mcast_query_interval 12500 \
520-
mcast_query_response_interval 1000
525+
mcast_query_response_interval 1000 \
526+
mcast_membership_interval 26000
521527

522528
v3cleanup $swp1 $TEST_GROUP
523529
}

tools/testing/selftests/net/forwarding/bridge_mld.sh

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -479,10 +479,15 @@ mldv2exc_timeout_test()
479479
local X=("2001:db8:1::20" "2001:db8:1::30")
480480

481481
# GMI should be 3 seconds
482-
ip link set dev br0 type bridge mcast_query_interval 100 mcast_query_response_interval 100
482+
ip link set dev br0 type bridge mcast_query_interval 100 \
483+
mcast_query_response_interval 100 \
484+
mcast_membership_interval 300
483485

484486
mldv2exclude_prepare $h1
485-
ip link set dev br0 type bridge mcast_query_interval 500 mcast_query_response_interval 500
487+
ip link set dev br0 type bridge mcast_query_interval 500 \
488+
mcast_query_response_interval 500 \
489+
mcast_membership_interval 1500
490+
486491
$MZ $h1 -c 1 $MZPKT_ALLOW2 -q
487492
sleep 3
488493
bridge -j -d -s mdb show dev br0 \
@@ -514,7 +519,8 @@ mldv2exc_timeout_test()
514519
log_test "MLDv2 group $TEST_GROUP exclude timeout"
515520

516521
ip link set dev br0 type bridge mcast_query_interval 12500 \
517-
mcast_query_response_interval 1000
522+
mcast_query_response_interval 1000 \
523+
mcast_membership_interval 26000
518524

519525
mldv2cleanup $swp1
520526
}

0 commit comments

Comments
 (0)