Skip to content

Commit 34e5a54

Browse files
arunpravin24alexdeucher
authored andcommitted
Revert "drm/amdgpu: remove TOPDOWN flags when allocating VRAM in large bar system"
This reverts commit c105518. This patch disables the TOPDOWN flag for APU and few dGPU cards which has the VRAM size equal to the BAR size. When we enable the TOPDOWN flag, we get the free blocks at the highest available memory region and we don't split the lower order blocks. This change is required to keep off the fragmentation related issues particularly in ASIC which has VRAM space <= 500MiB Hence, we are reverting this patch. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2270 Signed-off-by: Arunpravin Paneer Selvam <[email protected]> Reviewed-by: Christian König <[email protected]> Signed-off-by: Alex Deucher <[email protected]> Cc: [email protected]
1 parent 9db5ec1 commit 34e5a54

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
140140

141141
if (flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED)
142142
places[c].lpfn = visible_pfn;
143-
else if (adev->gmc.real_vram_size != adev->gmc.visible_vram_size)
143+
else
144144
places[c].flags |= TTM_PL_FLAG_TOPDOWN;
145145

146146
if (flags & AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS)

0 commit comments

Comments
 (0)