Skip to content

Commit 34fc9cc

Browse files
xypronConchuOD
authored andcommitted
riscv: dts: microchip: correct L2 cache interrupts
The "PolarFire SoC MSS Technical Reference Manual" documents the following PLIC interrupts: 1 - L2 Cache Controller Signals when a metadata correction event occurs 2 - L2 Cache Controller Signals when an uncorrectable metadata event occurs 3 - L2 Cache Controller Signals when a data correction event occurs 4 - L2 Cache Controller Signals when an uncorrectable data event occurs This differs from the SiFive FU540 which only has three L2 cache related interrupts. The sequence in the device tree is defined by an enum: enum {         DIR_CORR = 0,         DATA_CORR,         DATA_UNCORR,         DIR_UNCORR, }; So the correct sequence of the L2 cache interrupts is interrupts = <1>, <3>, <4>, <2>; [Conor] This manifests as an unusable system if the l2-cache driver is enabled, as the wrong interrupt gets cleared & the handler prints errors to the console ad infinitum. Fixes: 0fa6107 ("RISC-V: Initial DTS for Microchip ICICLE board") CC: [email protected] # 5.15: e35b07a: riscv: dts: microchip: mpfs: Group tuples in interrupt properties Signed-off-by: Heinrich Schuchardt <[email protected]> Signed-off-by: Conor Dooley <[email protected]>
1 parent 69dac8e commit 34fc9cc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/riscv/boot/dts/microchip/mpfs.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@
193193
cache-size = <2097152>;
194194
cache-unified;
195195
interrupt-parent = <&plic>;
196-
interrupts = <1>, <2>, <3>;
196+
interrupts = <1>, <3>, <4>, <2>;
197197
};
198198

199199
clint: clint@2000000 {

0 commit comments

Comments
 (0)