Skip to content

Commit 359bc01

Browse files
Jeff Johnsonidryomov
authored andcommitted
libceph: fix crush_choose_firstn() kernel-doc warnings
Currently, when built with "make W=1", the following warnings are generated: net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'work' not described in 'crush_choose_firstn' net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'weight' not described in 'crush_choose_firstn' net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'weight_max' not described in 'crush_choose_firstn' net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'choose_args' not described in 'crush_choose_firstn' Update the crush_choose_firstn() kernel-doc to document these parameters. Signed-off-by: Jeff Johnson <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: Ilya Dryomov <[email protected]>
1 parent 6463c36 commit 359bc01

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

net/ceph/crush/mapper.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,10 @@ static int is_out(const struct crush_map *map,
429429
/**
430430
* crush_choose_firstn - choose numrep distinct items of given type
431431
* @map: the crush_map
432+
* @work: working space initialized by crush_init_workspace()
432433
* @bucket: the bucket we are choose an item from
434+
* @weight: weight vector (for map leaves)
435+
* @weight_max: size of weight vector
433436
* @x: crush input value
434437
* @numrep: the number of items to choose
435438
* @type: the type of item to choose
@@ -445,6 +448,7 @@ static int is_out(const struct crush_map *map,
445448
* @vary_r: pass r to recursive calls
446449
* @out2: second output vector for leaf items (if @recurse_to_leaf)
447450
* @parent_r: r value passed from the parent
451+
* @choose_args: weights and ids for each known bucket
448452
*/
449453
static int crush_choose_firstn(const struct crush_map *map,
450454
struct crush_work *work,

0 commit comments

Comments
 (0)