Skip to content

Commit 359f5b0

Browse files
MarkMrLibroonie
authored andcommitted
spi: spi-rockchip: Fix missing unwind goto in rockchip_sfc_probe()
If devm_request_irq() fails, then we are directly return 'ret' without clk_disable_unprepare(sfc->clk) and clk_disable_unprepare(sfc->hclk). Fix this by changing direct return to a goto 'err_irq'. Fixes: 0b89fc0 ("spi: rockchip-sfc: add rockchip serial flash controller") Signed-off-by: Li Lanzhe <[email protected]> Reviewed-by: Dongliang Mu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent e8d018d commit 359f5b0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-rockchip-sfc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
632632
if (ret) {
633633
dev_err(dev, "Failed to request irq\n");
634634

635-
return ret;
635+
goto err_irq;
636636
}
637637

638638
ret = rockchip_sfc_init(sfc);

0 commit comments

Comments
 (0)