Skip to content

Commit 35b464e

Browse files
hvilleneuvedooojeda
authored andcommitted
auxdisplay: hd44780: move cursor home after clear display command
The DISPLAY_CLEAR command on the NewHaven NHD-0220DZW-AG5 display does NOT change the DDRAM address to 00h (home position) like the standard Hitachi HD44780 controller. As a consequence, the starting position of the initial string LCD_INIT_TEXT is not guaranteed to be at 0,0 depending on where the cursor was before the DISPLAY_CLEAR command. Extract of DISPLAY_CLEAR command from datasheets of: Hitachi HD44780: ... It then sets DDRAM address 0 into the address counter... NewHaven NHD-0220DZW-AG5 datasheet: ... This instruction does not change the DDRAM Address Move the cursor home after sending DISPLAY_CLEAR command to support non-standard LCDs. Signed-off-by: Hugo Villeneuve <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Tested-by: David Reaver <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
1 parent 2ccdd1b commit 35b464e

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

drivers/auxdisplay/hd44780_common.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,15 @@ int hd44780_common_clear_display(struct charlcd *lcd)
8282
hdc->write_cmd(hdc, LCD_CMD_DISPLAY_CLEAR);
8383
/* datasheet says to wait 1,64 milliseconds */
8484
long_sleep(2);
85-
return 0;
85+
86+
/*
87+
* The Hitachi HD44780 controller (and compatible ones) reset the DDRAM
88+
* address when executing the DISPLAY_CLEAR command, thus the
89+
* following call is not required. However, other controllers do not
90+
* (e.g. NewHaven NHD-0220DZW-AG5), thus move the cursor to home
91+
* unconditionally to support both.
92+
*/
93+
return hd44780_common_home(lcd);
8694
}
8795
EXPORT_SYMBOL_GPL(hd44780_common_clear_display);
8896

0 commit comments

Comments
 (0)