Skip to content

Commit 35b513a

Browse files
saschahauermmind
authored andcommitted
drm/rockchip: vop2: Fix eDP/HDMI sync polarities
The hsync/vsync polarities were not honoured for the eDP and HDMI ports. Add the register settings to configure the polarities as requested by the DRM_MODE_FLAG_PHSYNC/DRM_MODE_FLAG_PVSYNC flags. Signed-off-by: Sascha Hauer <[email protected]> Fixes: 604be85 ("drm/rockchip: Add VOP2 driver") Tested-by: Michael Riesch <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 235fdbc commit 35b513a

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,11 +1439,15 @@ static void rk3568_set_intf_mux(struct vop2_video_port *vp, int id,
14391439
die &= ~RK3568_SYS_DSP_INFACE_EN_HDMI_MUX;
14401440
die |= RK3568_SYS_DSP_INFACE_EN_HDMI |
14411441
FIELD_PREP(RK3568_SYS_DSP_INFACE_EN_HDMI_MUX, vp->id);
1442+
dip &= ~RK3568_DSP_IF_POL__HDMI_PIN_POL;
1443+
dip |= FIELD_PREP(RK3568_DSP_IF_POL__HDMI_PIN_POL, polflags);
14421444
break;
14431445
case ROCKCHIP_VOP2_EP_EDP0:
14441446
die &= ~RK3568_SYS_DSP_INFACE_EN_EDP_MUX;
14451447
die |= RK3568_SYS_DSP_INFACE_EN_EDP |
14461448
FIELD_PREP(RK3568_SYS_DSP_INFACE_EN_EDP_MUX, vp->id);
1449+
dip &= ~RK3568_DSP_IF_POL__EDP_PIN_POL;
1450+
dip |= FIELD_PREP(RK3568_DSP_IF_POL__EDP_PIN_POL, polflags);
14471451
break;
14481452
case ROCKCHIP_VOP2_EP_MIPI0:
14491453
die &= ~RK3568_SYS_DSP_INFACE_EN_MIPI0_MUX;

0 commit comments

Comments
 (0)