drm/nouveau/mmu: fix comptag memory leak

Ben Skeggs · Ben Skeggs · commit 35e4909b6a2b · 2020-01-23T08:56:51.000+10:00
Signed-off-by: Ben Skeggs &lt;bskeggs@redhat.com&gt;
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/memory.c b/drivers/gpu/drm/nouveau/nvkm/core/memory.c
@@ -91,8 +91,8 @@ nvkm_memory_tags_get(struct nvkm_memory *memory, struct nvkm_device *device,
 	}
 
 	refcount_set(&tags->refcount, 1);
+	*ptags = memory->tags = tags;
 	mutex_unlock(&fb->subdev.mutex);
-	*ptags = tags;
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ nvkm_memory_tags_get(struct nvkm_memory memory, struct nvkm_device device,`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`refcount_set(&tags->refcount, 1);`
	`94`	`+ *ptags = memory->tags = tags;`
`94`	`95`	`mutex_unlock(&fb->subdev.mutex);`
`95`		`- *ptags = tags;`
`96`	`96`	`return 0;`
`97`	`97`	`}`
`98`	`98`