Skip to content

Commit 361acac

Browse files
jhnikulaalexandrebelloni
authored andcommitted
i3c: mipi-i3c-hci: Remove BUG() when Ring Abort request times out
Ring Abort request will timeout in case there is an error in the Host Controller interrupt delivery or Ring Header configuration. Using BUG() makes hard to debug those cases. Make it less severe and turn BUG() to WARN_ON(). Signed-off-by: Jarkko Nikula <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent 45a832f commit 361acac

File tree

1 file changed

+1
-2
lines changed
  • drivers/i3c/master/mipi-i3c-hci

1 file changed

+1
-2
lines changed

drivers/i3c/master/mipi-i3c-hci/dma.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -450,10 +450,9 @@ static bool hci_dma_dequeue_xfer(struct i3c_hci *hci,
450450
/*
451451
* We're deep in it if ever this condition is ever met.
452452
* Hardware might still be writing to memory, etc.
453-
* Better suspend the world than risking silent corruption.
454453
*/
455454
dev_crit(&hci->master.dev, "unable to abort the ring\n");
456-
BUG();
455+
WARN_ON(1);
457456
}
458457

459458
for (i = 0; i < n; i++) {

0 commit comments

Comments
 (0)