Skip to content

Commit 36273e5

Browse files
Christoph Hellwigjankara
authored andcommitted
udf: remove ->writepage
->writepage is a very inefficient method to write back data, and only used through write_cache_pages or as a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation in extfat. Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Jan Kara <[email protected]>
1 parent a27c442 commit 36273e5

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

fs/udf/inode.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -182,11 +182,6 @@ static void udf_write_failed(struct address_space *mapping, loff_t to)
182182
}
183183
}
184184

185-
static int udf_writepage(struct page *page, struct writeback_control *wbc)
186-
{
187-
return block_write_full_page(page, udf_get_block, wbc);
188-
}
189-
190185
static int udf_writepages(struct address_space *mapping,
191186
struct writeback_control *wbc)
192187
{
@@ -239,12 +234,12 @@ const struct address_space_operations udf_aops = {
239234
.invalidate_folio = block_invalidate_folio,
240235
.read_folio = udf_read_folio,
241236
.readahead = udf_readahead,
242-
.writepage = udf_writepage,
243237
.writepages = udf_writepages,
244238
.write_begin = udf_write_begin,
245239
.write_end = generic_write_end,
246240
.direct_IO = udf_direct_IO,
247241
.bmap = udf_bmap,
242+
.migrate_folio = buffer_migrate_folio,
248243
};
249244

250245
/*

0 commit comments

Comments
 (0)