Skip to content

Commit 3634a4a

Browse files
committed
Merge tag 'fpga-for-5.6' of git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga into char-misc-next
Moritz writes: Here is the first set of FPGA changes for 5.6 The first two patches are minor cleanups to the DFL drivers, that remove unused warnings. The third patch removes a redundant error message to the ts73xx driver. The last patch removes a confusing print in case a call to devm_clk_get returns -EPROBE_DEFER. All patches have been reviewed on the mailing list and have been in the last couple of linux-next releases without issues. Signed-off-by: Moritz Fischer <[email protected]> * tag 'fpga-for-5.6' of git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga: fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer fpga: remove redundant dev_err message fpga: dfl: afu: remove set but not used variable 'afu' fpga: dfl: fme: remove set but not used variable 'fme'
2 parents 559e575 + 28910ce commit 3634a4a

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

drivers/fpga/dfl-afu-main.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -813,10 +813,8 @@ static int afu_dev_init(struct platform_device *pdev)
813813
static int afu_dev_destroy(struct platform_device *pdev)
814814
{
815815
struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
816-
struct dfl_afu *afu;
817816

818817
mutex_lock(&pdata->lock);
819-
afu = dfl_fpga_pdata_get_private(pdata);
820818
afu_mmio_region_destroy(pdata);
821819
afu_dma_region_destroy(pdata);
822820
dfl_fpga_pdata_set_private(pdata, NULL);

drivers/fpga/dfl-fme-main.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -675,10 +675,8 @@ static int fme_dev_init(struct platform_device *pdev)
675675
static void fme_dev_destroy(struct platform_device *pdev)
676676
{
677677
struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
678-
struct dfl_fme *fme;
679678

680679
mutex_lock(&pdata->lock);
681-
fme = dfl_fpga_pdata_get_private(pdata);
682680
dfl_fpga_pdata_set_private(pdata, NULL);
683681
mutex_unlock(&pdata->lock);
684682
}

drivers/fpga/ts73xx-fpga.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,8 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
119119

120120
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
121121
priv->io_base = devm_ioremap_resource(kdev, res);
122-
if (IS_ERR(priv->io_base)) {
123-
dev_err(kdev, "unable to remap registers\n");
122+
if (IS_ERR(priv->io_base))
124123
return PTR_ERR(priv->io_base);
125-
}
126124

127125
mgr = devm_fpga_mgr_create(kdev, "TS-73xx FPGA Manager",
128126
&ts73xx_fpga_ops, priv);

drivers/fpga/xilinx-pr-decoupler.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
101101

102102
priv->clk = devm_clk_get(&pdev->dev, "aclk");
103103
if (IS_ERR(priv->clk)) {
104-
dev_err(&pdev->dev, "input clock not found\n");
104+
if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
105+
dev_err(&pdev->dev, "input clock not found\n");
105106
return PTR_ERR(priv->clk);
106107
}
107108

0 commit comments

Comments
 (0)