Skip to content

Commit 363c327

Browse files
lkundrakvinodkoul
authored andcommitted
dmaengine: mmp_tdma: Do not ignore slave config validation errors
With an invalid dma_slave_config set previously, mmp_tdma_prep_dma_cyclic() would detect an error whilst configuring the channel, but proceed happily on: [ 120.756530] mmp-tdma d42a0800.adma: mmp_tdma: unknown burst size. Signed-off-by: Lubomir Rintel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 2e45676 commit 363c327

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/dma/mmp_tdma.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,8 @@ static struct dma_async_tx_descriptor *mmp_tdma_prep_dma_cyclic(
443443
if (!desc)
444444
goto err_out;
445445

446-
mmp_tdma_config_write(chan, direction, &tdmac->slave_config);
446+
if (mmp_tdma_config_write(chan, direction, &tdmac->slave_config))
447+
goto err_out;
447448

448449
while (buf < buf_len) {
449450
desc = &tdmac->desc_arr[i];

0 commit comments

Comments
 (0)