Skip to content

Commit 3649ff0

Browse files
bvanasscheaxboe
authored andcommitted
block: Document the role of the two attribute groups
It is nontrivial to derive the role of the two attribute groups in source file block/blk-sysfs.c. Hence add a comment that explains their roles. See also commit 6d85ebf ("blk-sysfs: add a new attr_group for blk_mq"). Cc: Christoph Hellwig <[email protected]> Cc: Yu Kuai <[email protected]> Signed-off-by: Bart Van Assche <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 67d995e commit 3649ff0

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

block/blk-sysfs.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,6 +615,7 @@ static ssize_t queue_wb_lat_store(struct request_queue *q, const char *page,
615615
QUEUE_RW_ENTRY(queue_wb_lat, "wbt_lat_usec");
616616
#endif
617617

618+
/* Common attributes for bio-based and request-based queues. */
618619
static struct attribute *queue_attrs[] = {
619620
&queue_ra_entry.attr,
620621
&queue_max_hw_sectors_entry.attr,
@@ -659,6 +660,7 @@ static struct attribute *queue_attrs[] = {
659660
NULL,
660661
};
661662

663+
/* Request-based queue attributes that are not relevant for bio-based queues. */
662664
static struct attribute *blk_mq_queue_attrs[] = {
663665
&queue_requests_entry.attr,
664666
&elv_iosched_entry.attr,

0 commit comments

Comments
 (0)