Skip to content

Commit 36dc3b1

Browse files
digetxthierryreding
authored andcommitted
ARM: tegra: Initialize r0 register for firmware wake-up
Downstream kernel of ASUS TF300T sets r0 to #3. There is no explanation in downstream code whether this is really needed and some of T30 downstream kernels have and explicit comment telling that all arguments are ignored by firmware. Let's take a safe side by replicating behavior of the TF300T downstream kernel. This change works fine on Ouya and Nexus 7 devices. Tested-by: Michał Mirosław <[email protected]> Tested-by: Jasper Korten <[email protected]> Tested-by: David Heidelberg <[email protected]> Tested-by: Peter Geis <[email protected]> Signed-off-by: Dmitry Osipenko <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
1 parent 836ca00 commit 36dc3b1

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

arch/arm/mach-tegra/reset-handler.S

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,12 @@ ENTRY(tegra_resume_trusted_foundations)
9898
reteq lr
9999

100100
.arch_extension sec
101-
/* First call after suspend wakes firmware. No arguments required. */
101+
/*
102+
* First call after suspend wakes firmware. No arguments required
103+
* for some firmware versions. Downstream kernel of ASUS TF300T uses
104+
* r0=3 for the wake-up notification.
105+
*/
106+
mov r0, #3
102107
smc #0
103108

104109
b cpu_resume

0 commit comments

Comments
 (0)